[Qemu-devel] [PATCH v2] qxl+vnc: register a vm state change handler for dummy spice_server

[Qemu-devel] [PATCH v2] qxl+vnc: register a vm state change handler for dummy spice_server

[Uri Lublin]

When qxl + vnc are used, a dummy spice_server is initialized.
The spice_server has to be told when the VM runstate changes,
which is what this patch does.

Without it, from qxl_send_events(), the following error message is shown:
  qxl_send_events: spice-server bug: guest stopped, ignoring

Signed-off-by: Uri Lublin <uril@redhat.com>
---

v1 -> v2: make checkpatch happy

---
 ui/spice-core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 261c6f2..59ce5f6 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -732,6 +732,8 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
          */
         spice_server = spice_server_new();
         spice_server_init(spice_server, &core_interface);
+        qemu_add_vm_change_state_handler(vm_change_state_handler,
+                                         &spice_server);
     }
 
     return spice_server_add_interface(spice_server, sin);
-- 
1.7.1

Re: [Qemu-devel] [PATCH v2] qxl+vnc: register a vm state change handler for dummy spice_server

[Gerd Hoffmann]

On 12/12/12 17:30, Uri Lublin wrote:
> When qxl + vnc are used, a dummy spice_server is initialized.
> The spice_server has to be told when the VM runstate changes,
> which is what this patch does.
> 
> Without it, from qxl_send_events(), the following error message is shown:
>   qxl_send_events: spice-server bug: guest stopped, ignoring

Patch added to spice patch queue.

thanks,
  Gerd