From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkalD-0005FV-H9 for qemu-devel@nongnu.org; Mon, 17 Dec 2012 08:29:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkalC-00023Q-HZ for qemu-devel@nongnu.org; Mon, 17 Dec 2012 08:29:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkalC-00023B-9o for qemu-devel@nongnu.org; Mon, 17 Dec 2012 08:29:34 -0500 Message-ID: <50CF1E2F.2020101@redhat.com> Date: Mon, 17 Dec 2012 14:29:19 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1355629786-14649-1-git-send-email-andreas.faerber@web.de> <1355629786-14649-2-git-send-email-andreas.faerber@web.de> In-Reply-To: <1355629786-14649-2-git-send-email-andreas.faerber@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI EHCI split List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org On 12/16/12 04:49, Andreas F=C3=A4rber wrote: > SysBus EHCI was introduced in a hurry before 1.3 Soft Freeze. > To use QOM casts in place of DO_UPCAST() / FROM_SYSBUS(), we need an > identifying type. Introduce generic abstract base types for PCI and > SysBus EHCI to allow multiple types to access the shared fields. >=20 > While at it, move the state structs being amended with macros to the > header file so that they can be embedded. --verbose please. I fail to see the point. EHCIPCIState should not be needed outside of hcd-ehci-pci.c and I'd prefer to leave it there. Likewise for sysbus. cheers, Gerd