From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46500)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TkbZc-0002D4-3I
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 09:21:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TkbZa-0000Vt-3n
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 09:21:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1TkbZZ-0000Vo-SN
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 09:21:38 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBHELaSb016949
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 17 Dec 2012 09:21:36 -0500
Message-ID: <50CF2AFB.2050705@redhat.com>
Date: Mon, 17 Dec 2012 15:23:55 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1355492147-5023-1-git-send-email-hdegoede@redhat.com>
	<1355492147-5023-10-git-send-email-hdegoede@redhat.com>
	<50CF1B33.7060708@redhat.com>
In-Reply-To: <50CF1B33.7060708@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for
 interrupt threshold checking
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Hi,

On 12/17/2012 02:16 PM, Gerd Hoffmann wrote:
> On 12/14/12 14:35, Hans de Goede wrote:
>> Note that a shadow variable is used instead of changing frindex to
>> uframe accuracy because we must send a frindex which is a multiple of 8
>> during migration for migration compatibility, and rounding it down to
>> a multiple of 8 pre-migration, can lead to frindex going backwards from
>> the guest pov.
>
> Jumping forward instead?

You mean rounding the send frindex up pre-migration, I didn't really consider
that as it will cause us skipping processing an entry in the periodic frame
list. I guess doing that on migration isn't too bad. OTOH giving the guest
only frame accuracy like we've been doing till now also works fine...

Your choice :)

Regards,

Hans