From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TkgcS-0006Nl-50
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 14:44:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TkgcN-0004sN-Au
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 14:44:56 -0500
Received: from cantor2.suse.de ([195.135.220.15]:44321 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TkgcN-0004s1-53
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 14:44:51 -0500
Message-ID: <50CF7629.2070309@suse.de>
Date: Mon, 17 Dec 2012 20:44:41 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1355773201-11576-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1355773201-11576-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings
 (wrong format specifiers)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Fabien Chouteau <chouteau@adacore.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 17.12.2012 20:40, schrieb Stefan Weil:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statement=
s
> with wrong format specifiers.
>=20
> GetLastError() returns a DWORD which is unsigned long, so %lu must be u=
sed.
>=20
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>=20
> Do we want those fprintf statements here at all?

I believe it was argued that otherwise you cannot distinguish where the
EIO came from.

Andreas

>  block/raw-win32.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/block/raw-win32.c b/block/raw-win32.c
> index ce207a3..a2e155e 100644
> --- a/block/raw-win32.c
> +++ b/block/raw-win32.c
> @@ -314,11 +314,11 @@ static int raw_truncate(BlockDriverState *bs, int=
64_t offset)
>       */
>      dwPtrLow =3D SetFilePointer(s->hfile, low, &high, FILE_BEGIN);
>      if (dwPtrLow =3D=3D INVALID_SET_FILE_POINTER && GetLastError() !=3D=
 NO_ERROR) {
> -        fprintf(stderr, "SetFilePointer error: %d\n", GetLastError());
> +        fprintf(stderr, "SetFilePointer error: %lu\n", GetLastError())=
;
>          return -EIO;
>      }
>      if (SetEndOfFile(s->hfile) =3D=3D 0) {
> -        fprintf(stderr, "SetEndOfFile error: %d\n", GetLastError());
> +        fprintf(stderr, "SetEndOfFile error: %lu\n", GetLastError());
>          return -EIO;
>      }
>      return 0;
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg