From: Gerd Hoffmann <kraxel@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jason Baron <jbaron@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI EHCI split
Date: Tue, 18 Dec 2012 09:02:16 +0100 [thread overview]
Message-ID: <50D02308.3050307@redhat.com> (raw)
In-Reply-To: <50CF530C.80905@web.de>
Hi,
>> I fail to see the point. EHCIPCIState should not be needed outside of
>> hcd-ehci-pci.c and I'd prefer to leave it there. Likewise for sysbus.
>
> It is exactly what I commented on my v1 for needing a v2 and you seemed
> to concur... In C, to embed a struct in another struct the compiler
> needs the full struct definition (compare i440fx, prep_pci series) and
> it thus needs to be in an #include'able header.
Sure.
> @@ -115,6 +115,9 @@ typedef struct Tegra2State {
> TegraClocksState clocks;
> SDHCIState sdhci[4];
> TegraI2CState i2c[4];
> +#if 0
> + EHCISysBusState usb[3];
> +#endif
> } Tegra2State;
Ah, *that* is the place where you need it (outside hcd-ehci-sysbus.c).
Makes sense indeed.
I'll go put the bits as-is into the usb queue.
cheers,
Gerd
next prev parent reply other threads:[~2012-12-18 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 3:49 [Qemu-devel] [PATCH v2 0/4] usb: Clean up and extend SysBus EHCI Andreas Färber
2012-12-16 3:49 ` [Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI EHCI split Andreas Färber
2012-12-17 13:29 ` Gerd Hoffmann
2012-12-17 17:14 ` Andreas Färber
2012-12-18 8:02 ` Gerd Hoffmann [this message]
2012-12-16 3:49 ` [Qemu-devel] [PATCH v2 2/4] usb/ehci: Move capsbase and opregbase into SysBus EHCI class Andreas Färber
2012-12-16 3:49 ` [Qemu-devel] [PATCH v2 3/4] usb/ehci: Add SysBus EHCI device for Exynos4210 Andreas Färber
2012-12-17 11:02 ` Igor Mitsyanko
2012-12-16 3:49 ` [Qemu-devel] [PATCH v2 4/4] exynos4210: Add EHCI support Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D02308.3050307@redhat.com \
--to=kraxel@redhat.com \
--cc=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=jbaron@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).