From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41231)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Tks88-0007Rj-FV
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 03:02:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Tks87-0004nH-8a
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 03:02:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47597)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Tks87-0004n9-1t
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 03:02:23 -0500
Message-ID: <50D02308.3050307@redhat.com>
Date: Tue, 18 Dec 2012 09:02:16 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1355629786-14649-1-git-send-email-andreas.faerber@web.de>
	<1355629786-14649-2-git-send-email-andreas.faerber@web.de>
	<50CF1E2F.2020101@redhat.com> <50CF530C.80905@web.de>
In-Reply-To: <50CF530C.80905@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI
	EHCI split
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Jason Baron <jbaron@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

  Hi,

>> I fail to see the point.  EHCIPCIState should not be needed outside of
>> hcd-ehci-pci.c and I'd prefer to leave it there.  Likewise for sysbus.
> 
> It is exactly what I commented on my v1 for needing a v2 and you seemed
> to concur... In C, to embed a struct in another struct the compiler
> needs the full struct definition (compare i440fx, prep_pci series) and
> it thus needs to be in an #include'able header.

Sure.

> @@ -115,6 +115,9 @@ typedef struct Tegra2State {
>      TegraClocksState clocks;
>      SDHCIState sdhci[4];
>      TegraI2CState i2c[4];
> +#if 0
> +    EHCISysBusState usb[3];
> +#endif
>  } Tegra2State;

Ah, *that* is the place where you need it (outside hcd-ehci-sysbus.c).
Makes sense indeed.

I'll go put the bits as-is into the usb queue.

cheers,
  Gerd