From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41120)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tky84-0000LJ-PO
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:26:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tky82-0004cI-SG
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:26:44 -0500
Received: from cantor2.suse.de ([195.135.220.15]:46835 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tky82-0004cB-Lh
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:26:42 -0500
Message-ID: <50D07D1A.1080204@suse.de>
Date: Tue, 18 Dec 2012 15:26:34 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1353335052.git.jan.kiszka@siemens.com>
	<50C851EA.9040903@siemens.com>
In-Reply-To: <50C851EA.9040903@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Stefan Weil <weil@mail.berlios.de>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 12.12.2012 10:44, schrieb Jan Kiszka:
> On 2012-11-19 15:24, Jan Kiszka wrote:
>> See patches for details.
>>
>> Jan Kiszka (2):
>>   i2c: Introduce device address mask
>>   Add AT24Cxx I2C EEPROM device model
>>
>>  hw/Makefile.objs |    2 +-
>>  hw/at24.c        |  363 +++++++++++++++++++++++++++++++++++++++++++++=
+++++++++
>>  hw/ds1338.c      |    2 +-
>>  hw/i2c.c         |    9 +-
>>  hw/i2c.h         |    3 +-
>>  hw/lm832x.c      |    2 +-
>>  hw/max7310.c     |    2 +-
>>  hw/pxa2xx.c      |    3 +-
>>  hw/smbus.c       |    2 +-
>>  hw/ssd0303.c     |    2 +-
>>  hw/tmp105.c      |    2 +-
>>  hw/tosa.c        |    2 +-
>>  hw/twl92230.c    |    2 +-
>>  hw/wm8750.c      |    2 +-
>>  hw/z2.c          |    2 +-
>>  15 files changed, 383 insertions(+), 17 deletions(-)
>>  create mode 100644 hw/at24.c
>>
>=20
> Ping. Both still apply over latest master, and addressable review
> comments are not pending according to my understanding.

Hello Jan, did you see my recent proposal of an I2C qtest framework? :)
For one I'd be interested in feedback from someone who knows I2C and for
another maybe you could follow-up your patch with some test case (I2C
master shouldn't matter, I guess).

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg