From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl4nx-0001SK-Pu for qemu-devel@nongnu.org; Tue, 18 Dec 2012 16:34:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tl4nw-0000Wy-GM for qemu-devel@nongnu.org; Tue, 18 Dec 2012 16:34:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl4nw-0000Up-6u for qemu-devel@nongnu.org; Tue, 18 Dec 2012 16:34:24 -0500 Message-ID: <50D0E158.9070004@redhat.com> Date: Tue, 18 Dec 2012 14:34:16 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355500182-12743-1-git-send-email-lcapitulino@redhat.com> <1355500182-12743-2-git-send-email-lcapitulino@redhat.com> <24E144B8C0207547AD09C467A8259F75578B48B1@lisa.maurer-it.com> In-Reply-To: <24E144B8C0207547AD09C467A8259F75578B48B1@lisa.maurer-it.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig10E6B76FC6AA2893E485136C" Subject: Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer Cc: "mdroth@linux.vnet.ibm.com" , "aliguori@us.ibm.com" , "agl@us.ibm.com" , "qemu-devel@nongnu.org" , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10E6B76FC6AA2893E485136C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/17/2012 03:13 AM, Dietmar Maurer wrote: >> Next commit will re-enable balloon stats with a different interface, b= ut this >> old code conflicts with it. Let's drop it. >=20 > I don't really see any conflicts here? >=20 >> It's important to note that the QMP and HMP interfaces are also droppe= d by >> this commit. That shouldn't be a problem though, because: >> >> 1. All QMP fields are optional >> 2. This has never been really used Libvirt has been using it when available (although reluctantly, as it risks hanging on an uncooperative guest); and while libvirt can be patched to call 6 QOM commands in a row to query six different QOM stats, I still think it would be nicer to add a command that provides all the stats at once. In particular, when calling 6 commands in series, you no longer have an atomic picture of the guest (the polling interval could hit between two QOM queries, resulting in a combined set of statistics that has no counterpart to the transition of states that the guest actually went through). On the other hand, since the stats are already polling-based, and since it requires cooperation from the guest, not having a guarantee of an atomic set of stats is not really much of a loss. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig10E6B76FC6AA2893E485136C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ0OFZAAoJEKeha0olJ0NqgCgIAIb79fbakM0F3aGuMBLzheJv 73b1934fPO7sAqdO37jxWLBegD/tYdq5Y/6ZWcblZs5MkNy3DHXbP/B35vdSJ9qy pXO88hQRAI7zO+luRohDfawh6HxKGiuq8RWdOV1zw6BwLtgncIStr3tha33HZy++ pfPxb3uSsDOCAn7CdGDiU0PPvY4H3IBjzrHLDgG8TlI3j/KmLlBLF1K3FOkW9Krq Nz0GJV8F5xJWckIcTPPRWboj0wORHdF8LikXj2/BcC1ZxcopLtCvzTk7HMfybomh Pi2e07RMg60FjawJsfe/jsaLnS93bV4U9MIt4STc1ubnW9YDvkgAgftNYC0SAlE= =PoRP -----END PGP SIGNATURE----- --------------enig10E6B76FC6AA2893E485136C--