From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl5fy-0000TA-Lm for qemu-devel@nongnu.org; Tue, 18 Dec 2012 17:30:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tl5fx-0007W5-53 for qemu-devel@nongnu.org; Tue, 18 Dec 2012 17:30:14 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33784 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl5fw-0007Vu-Ur for qemu-devel@nongnu.org; Tue, 18 Dec 2012 17:30:13 -0500 Message-ID: <50D0EE6A.6070204@suse.de> Date: Tue, 18 Dec 2012 23:30:02 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354726153-30264-1-git-send-email-ehabkost@redhat.com> <1354726153-30264-7-git-send-email-ehabkost@redhat.com> In-Reply-To: <1354726153-30264-7-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , Don Slutz , qemu-devel@nongnu.org Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This separates the qdev properties code in two parts: > - qdev-properties.c, that contains most of the qdev properties code; > - qdev-properties-system.c for code specific for qemu-system-*, > containing: > - Property types: drive, chr, netdev, vlan, that depend on code that > won't be included on *-user > - qemu_add_globals(), that depends on qemu-config.o. >=20 > This change should help on two things: > - Allowing DeviceState to be used by *-user without pulling > dependencies that are specific for qemu-system-*; > - Writing qdev unit tests without pulling too many dependencies. >=20 > The copyright/license of qdev-properties.c isn't explicitly stated at > the file, so add a simple copyright/license header pointing to the > commit ID of the original file. >=20 > Signed-off-by: Eduardo Habkost I dropped a trailing white line in qdev-properties-system.c; otherwise it passed checkpatch.pl cleanly now. I verified that nothing got lost or accidentally changed during the code movement. Thanks, applied to qom-cpu queue: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg