From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36349)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TlASD-0002mT-P2
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 22:36:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TlASC-0005DF-Fo
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 22:36:21 -0500
Message-ID: <50D12A72.6030801@suse.de>
Date: Wed, 19 Dec 2012 03:46:10 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1355817223-13076-1-git-send-email-afaerber@suse.de>
	<1355817223-13076-4-git-send-email-afaerber@suse.de>
In-Reply-To: <1355817223-13076-4-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu 3/4] target-ppc: Slim conversion of
 model definitions to QOM subclasses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-ppc <qemu-ppc@nongnu.org>, qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>, David Gibson <david@gibson.dropbear.id.au>

Am 18.12.2012 08:53, schrieb Andreas F=C3=A4rber:
> +static gint ppc_cpu_compare_class_name(gconstpointer a, gconstpointer =
b)
> +{
> +    ObjectClass *oc =3D (ObjectClass *)a;
> +    const char *name =3D b;
> =20
> -    return NULL;
> +    if (strncasecmp(name, object_class_get_name(oc), strlen(name)) =3D=
=3D 0 &&
> +        strcmp(object_class_get_name(oc) + strlen(name),
> +               "-" TYPE_POWERPC_CPU) =3D=3D 0) {
> +        return 0;
> +    }
> +    return -1;
>  }
> =20
>  #include <ctype.h>
> =20
> -const ppc_def_t *cpu_ppc_find_by_name (const char *name)
> +static ObjectClass *ppc_cpu_class_by_name(const char *name)
[...]
> +    list =3D object_class_get_list(TYPE_POWERPC_CPU, false);
> +    item =3D g_slist_find_custom(list, name, ppc_cpu_compare_class_nam=
e);
> +    if (item !=3D NULL) {
> +        ret =3D OBJECT_CLASS(item->data);
>      }
> +    g_slist_free(list);
> =20
>      return ret;
>  }
[...]
> +static void ppc_cpu_register_model(const ppc_def_t *def)
> +{
> +    TypeInfo type_info =3D {
> +        .name =3D def->name,
> +        .parent =3D TYPE_POWERPC_CPU,
> +        .class_init =3D ppc_cpu_def_class_init,
> +        .class_data =3D (void *)def,
> +    };
> +
> +    type_register(&type_info);
>  }

Err, needs the following fix:

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 908a558..ad0763e 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -10446,13 +10446,14 @@ static void ppc_cpu_def_class_init(ObjectClass
*oc, void *data)
 static void ppc_cpu_register_model(const ppc_def_t *def)
 {
     TypeInfo type_info =3D {
-        .name =3D def->name,
         .parent =3D TYPE_POWERPC_CPU,
         .class_init =3D ppc_cpu_def_class_init,
         .class_data =3D (void *)def,
     };

+    type_info.name =3D g_strdup_printf("%s-" TYPE_POWERPC_CPU, def->name=
),
     type_register(&type_info);
+    g_free((gpointer)type_info.name);
 }

 /* CPUClass::reset() */

Not sure how I managed to screw this up so badly, seems I tested corner
cases and -cpu host too much...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg