From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlLkK-0006Cj-VE for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:39:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlLkD-0002Wv-LD for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:39:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlLkD-0002Wj-AW for qemu-devel@nongnu.org; Wed, 19 Dec 2012 10:39:41 -0500 Message-ID: <50D1DFB8.8050309@redhat.com> Date: Wed, 19 Dec 2012 17:39:36 +0200 From: Uri Lublin MIME-Version: 1.0 References: <1355922436-8378-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1355922436-8378-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque Reply-To: uril@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel@nongnu.org, Gerd Hoffmann On 12/19/2012 03:07 PM, Stefan Hajnoczi wrote: > The spice_server pointer is a global variable and ... is a static variable in ui/spice-core.c and > vm_change_state_handler() therefore does not use its opaque parameter. > > The vm change state handler is added with a pointer to the spice_server > pointer. This is useless and we probably would not want 2 levels of > pointers. Reviewed-by: Uri Lublin > > Signed-off-by: Stefan Hajnoczi > --- > ui/spice-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index ac46deb..c128c0b 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -709,7 +709,7 @@ void qemu_spice_init(void) > qemu_spice_input_init(); > qemu_spice_audio_init(); > > - qemu_add_vm_change_state_handler(vm_change_state_handler,&spice_server); > + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); > > g_free(x509_key_file); > g_free(x509_cert_file); > @@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin) > */ > spice_server = spice_server_new(); > spice_server_init(spice_server,&core_interface); > - qemu_add_vm_change_state_handler(vm_change_state_handler, > -&spice_server); > + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); > } > > return spice_server_add_interface(spice_server, sin);