From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlMOn-0002Q7-Gv for qemu-devel@nongnu.org; Wed, 19 Dec 2012 11:21:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlMOi-0005Zb-Sr for qemu-devel@nongnu.org; Wed, 19 Dec 2012 11:21:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlMOi-0005ZW-Kf for qemu-devel@nongnu.org; Wed, 19 Dec 2012 11:21:32 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBJGLV9A015085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Dec 2012 11:21:31 -0500 Message-ID: <50D1E987.1050402@redhat.com> Date: Wed, 19 Dec 2012 17:21:27 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> <1355932747-1755-9-git-send-email-kraxel@redhat.com> In-Reply-To: <1355932747-1755-9-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 8/9] chardev: hotplug, qmp, serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: mprivozn@redhat.com, qemu-devel@nongnu.org Il 19/12/2012 16:59, Gerd Hoffmann ha scritto: > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 3 ++- > qemu-char.c | 16 ++++++++++++++-- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 7e5c8c2..d833385 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3036,7 +3036,8 @@ > { 'type': 'ChardevFile', 'data': { '*in' : 'ChardevFileSource', > 'out' : 'ChardevFileSource' } } > > -{ 'enum': 'ChardevPortKind', 'data': [ 'tty' ] } > +{ 'enum': 'ChardevPortKind', 'data': [ 'tty', > + 'serial' ] } I think 'tty' and 'serial' are really the same thing, just one for Windows and one for Linux. We could make one a synonym of the other, even for -chardev. Paolo > { 'type': 'ChardevPort', 'data': { 'device' : 'ChardevFileSource', > 'type' : 'ChardevPortKind'} } > diff --git a/qemu-char.c b/qemu-char.c > index 28e4991..9f23c25 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -1662,9 +1662,8 @@ static int win_chr_poll(void *opaque) > return 0; > } > > -static CharDriverState *qemu_chr_open_win(QemuOpts *opts) > +static CharDriverState *qemu_chr_open_win_path(const char *filename) > { > - const char *filename = qemu_opt_get(opts, "path"); > CharDriverState *chr; > WinCharState *s; > > @@ -1683,6 +1682,11 @@ static CharDriverState *qemu_chr_open_win(QemuOpts *opts) > return chr; > } > > +static CharDriverState *qemu_chr_open_win(QemuOpts *opts) > +{ > + return qemu_chr_open_win_path(qemu_opt_get(opts, "path")); > +} > + > static int win_chr_pipe_poll(void *opaque) > { > CharDriverState *chr = opaque; > @@ -2957,7 +2961,14 @@ static CharDriverState *qmp_chardev_open_file(ChardevFile *file, Error **errp) > > static CharDriverState *qmp_chardev_open_port(ChardevPort *port, Error **errp) > { > + if (port->device->kind != CHARDEV_FILE_SOURCE_KIND_PATH) { > + error_setg(errp, "only file paths supported"); > + return NULL; > + } > + > switch (port->type) { > + case CHARDEV_PORT_KIND_SERIAL: > + return qemu_chr_open_win_path(port->device->path); > default: > error_setg(errp, "unknown chardev port (%d)", port->type); > return NULL; > @@ -3020,6 +3031,7 @@ static CharDriverState *qmp_chardev_open_port(ChardevPort *port, Error **errp) > switch (port->type) { > #ifdef HAVE_CHARDEV_TTY > case CHARDEV_PORT_KIND_TTY: > + case CHARDEV_PORT_KIND_SERIAL: > flags = O_RDWR | O_NONBLOCK; > fd = qmp_chardev_open_file_source(port->device, flags, errp); > if (error_is_set(errp)) { >