From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlaFz-0007Xp-5R for qemu-devel@nongnu.org; Thu, 20 Dec 2012 02:09:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlaFw-0005bc-Hn for qemu-devel@nongnu.org; Thu, 20 Dec 2012 02:09:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlaFw-0005bT-Ac for qemu-devel@nongnu.org; Thu, 20 Dec 2012 02:09:24 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBK79Nlk014581 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Dec 2012 02:09:23 -0500 Message-ID: <50D2B9A1.6090902@redhat.com> Date: Thu, 20 Dec 2012 08:09:21 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> <1355932747-1755-9-git-send-email-kraxel@redhat.com> <50D1E987.1050402@redhat.com> In-Reply-To: <50D1E987.1050402@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 8/9] chardev: hotplug, qmp, serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: mprivozn@redhat.com, qemu-devel@nongnu.org On 12/19/12 17:21, Paolo Bonzini wrote: > Il 19/12/2012 16:59, Gerd Hoffmann ha scritto: >> Signed-off-by: Gerd Hoffmann >> --- >> qapi-schema.json | 3 ++- >> qemu-char.c | 16 ++++++++++++++-- >> 2 files changed, 16 insertions(+), 3 deletions(-) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 7e5c8c2..d833385 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -3036,7 +3036,8 @@ >> { 'type': 'ChardevFile', 'data': { '*in' : 'ChardevFileSource', >> 'out' : 'ChardevFileSource' } } >> >> -{ 'enum': 'ChardevPortKind', 'data': [ 'tty' ] } >> +{ 'enum': 'ChardevPortKind', 'data': [ 'tty', >> + 'serial' ] } > > I think 'tty' and 'serial' are really the same thing, just one for > Windows and one for Linux. Partly disagree. tty is a very unix-ish concept, having that on windows would be confusing I think. serial lines happen to be a subset of tty on linux. The patch aliases serial to tty on unix because of that. > We could make one a synonym of the other, even for -chardev. Makes sense to be consistent here. cheers, Gerd