From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tldh3-0007Vy-8o for qemu-devel@nongnu.org; Thu, 20 Dec 2012 05:49:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tldh0-0002l8-Bn for qemu-devel@nongnu.org; Thu, 20 Dec 2012 05:49:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tldh0-0002kb-4j for qemu-devel@nongnu.org; Thu, 20 Dec 2012 05:49:34 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBKAnV8Q018926 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Dec 2012 05:49:32 -0500 Message-ID: <50D2ED39.6010608@redhat.com> Date: Thu, 20 Dec 2012 11:49:29 +0100 From: Michal Privoznik MIME-Version: 1.0 References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1355932747-1755-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On 19.12.2012 16:58, Gerd Hoffmann wrote: > Hi, > > Chardev hotplug patch series reloaded. Not finished yet, commit > messages not finalized yet, totally untested other than building on > linux+windows. > > I doubt I manage to finish (and test!) it before xmas. Nevertheless I > wanna get the bits out of the door for you to see what is coming and for > early reviews. It goes largely the route suggested by Paolo. > > cheers, > Gerd > > Gerd Hoffmann (9): > chardev: add error reporting for qemu_chr_new_from_opts > chardev: fix QemuOpts lifecycle > chardev: reduce chardev ifdef mess a bit > chardev: hotplug, qmp, null > chardev: hotplug, hmp > chardev: hotplug, qmp, file > chardev: hotplug, qmp, tty > chardev: hotplug, qmp, serial > chardev: hotplug, qmp, parallel > > hmp-commands.hx | 32 ++++++ > hmp.c | 23 +++++ > hmp.h | 2 + > qapi-schema.json | 47 +++++++++ > qemu-char.c | 280 ++++++++++++++++++++++++++++++++++++++++++++--------- > qemu-char.h | 4 +- > qmp-commands.hx | 50 ++++++++++ > vl.c | 9 +- > 8 files changed, 395 insertions(+), 52 deletions(-) > Okay, the QMP interface seems sane to me (from libvirt POV). However, what about other chardev types like pipe and vc? And I guess pty can be covered by tty, right? Michal