From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TleZL-00056l-IP for qemu-devel@nongnu.org; Thu, 20 Dec 2012 06:45:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TleZE-0008Fk-QY for qemu-devel@nongnu.org; Thu, 20 Dec 2012 06:45:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TleZE-0008Fd-Ie for qemu-devel@nongnu.org; Thu, 20 Dec 2012 06:45:36 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBKBjZOs031559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Dec 2012 06:45:36 -0500 Message-ID: <50D2FA5D.30602@redhat.com> Date: Thu, 20 Dec 2012 12:45:33 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> <50D2ED39.6010608@redhat.com> <20121220105643.GK25577@redhat.com> <50D2F23D.9000908@redhat.com> In-Reply-To: <50D2F23D.9000908@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Michal Privoznik , qemu-devel@nongnu.org >>>> I doubt I manage to finish (and test!) it before xmas. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>> Okay, the QMP interface seems sane to me (from libvirt POV). However, >>> what about other chardev types like pipe and vc? And I guess pty can be >>> covered by tty, right? > > I think that is the missing part. Exactly. /me wades through the socket code (unix+tcp) right now, which needs some refactoring to make it fly. >> From libvirt's POV, I think the most important chardev types are pty, >> unix and tcp. The other types are pretty rarely used AFAICT. pty looks like another non-trivial challenge. How does libvirt gather the pty device today? IIRC there is some stderr parsing? Or was it info chardev? With QMP we probably want switch to a more sane model here ... cheers, Gerd