From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tlha0-0000So-E6 for qemu-devel@nongnu.org; Thu, 20 Dec 2012 09:58:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlhZx-0005h5-H1 for qemu-devel@nongnu.org; Thu, 20 Dec 2012 09:58:36 -0500 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:42608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlhZw-0005gX-Tk for qemu-devel@nongnu.org; Thu, 20 Dec 2012 09:58:33 -0500 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Dec 2012 20:27:51 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 4448EE004B for ; Thu, 20 Dec 2012 20:28:16 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBKEwNcs16187634 for ; Thu, 20 Dec 2012 20:28:23 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBKEwNit020874 for ; Fri, 21 Dec 2012 01:58:24 +1100 Message-ID: <50D3278C.6060306@linux.vnet.ibm.com> Date: Thu, 20 Dec 2012 22:58:20 +0800 From: Lei Li MIME-Version: 1.0 References: <1356014948-13450-1-git-send-email-lilei@linux.vnet.ibm.com> In-Reply-To: <1356014948-13450-1-git-send-email-lilei@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-char: inherit ptys and imporve output from -serial pty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: qemu-devel@nongnu.org Sorry, s/imporve/improve... On 12/20/2012 10:49 PM, Lei Li wrote: > When controlling a qemu instance from another program, it's > hard to know which serial port or monitor device is redirected > to which pty. With more than one device using "pty" a lot of > guesswork is involved. > > $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty > char device redirected to /dev/pts/5 > char device redirected to /dev/pts/6 > char device redirected to /dev/pts/7 > > Although we can find out what everything else is connected to > by the "info chardev" with "-monitor stdio" in the command line, > It'd be very useful to be able to have qemu inherit pseudo-tty > file descriptors so they could just be specified on the command > line like: > > $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty > char device compat_monitor0 redirected to /dev/pts/5 > char device serial0 redirected to /dev/pts/6 > char device serial1 redirected to /dev/pts/7 > > Referred link: https://bugs.launchpad.net/qemu/+bug/938552 > > Reported-by: Craig Ringer > Signed-off-by: Lei Li > --- > qemu-char.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 242b799..2b0f5f4 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -981,6 +981,7 @@ static CharDriverState *qemu_chr_open_pty(QemuOpts *opts) > CharDriverState *chr; > PtyCharDriver *s; > struct termios tty; > + char *label; > int master_fd, slave_fd, len; > #if defined(__OpenBSD__) || defined(__DragonFly__) > char pty_name[PATH_MAX]; > @@ -1006,7 +1007,8 @@ static CharDriverState *qemu_chr_open_pty(QemuOpts *opts) > chr->filename = g_malloc(len); > snprintf(chr->filename, len, "pty:%s", q_ptsname(master_fd)); > qemu_opt_set(opts, "path", q_ptsname(master_fd)); > - fprintf(stderr, "char device redirected to %s\n", q_ptsname(master_fd)); > + label = g_strdup(qemu_opts_id(opts)); > + fprintf(stderr, "char device %s redirected to %s\n", label, q_ptsname(master_fd)); > > s = g_malloc0(sizeof(PtyCharDriver)); > chr->opaque = s; -- Lei