From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlyZr-0000KL-SD for qemu-devel@nongnu.org; Fri, 21 Dec 2012 04:07:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TlyUM-0003sC-Tw for qemu-devel@nongnu.org; Fri, 21 Dec 2012 04:02:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlyUM-0003rm-KC for qemu-devel@nongnu.org; Fri, 21 Dec 2012 04:01:54 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBL91oqL028537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Dec 2012 04:01:53 -0500 Message-ID: <50D4257A.7050402@redhat.com> Date: Fri, 21 Dec 2012 10:01:46 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> <50D2ED39.6010608@redhat.com> <20121220105643.GK25577@redhat.com> <50D2F23D.9000908@redhat.com> <50D2FA5D.30602@redhat.com> <20121220164426.GA27510@redhat.com> In-Reply-To: <20121220164426.GA27510@redhat.com> Content-Type: multipart/mixed; boundary="------------080905030600090307070102" Subject: Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Paolo Bonzini , qemu-devel@nongnu.org, Michal Privoznik This is a multi-part message in MIME format. --------------080905030600090307070102 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, >> pty looks like another non-trivial challenge. How does libvirt gather >> the pty device today? IIRC there is some stderr parsing? Or was it >> info chardev? With QMP we probably want switch to a more sane model >> here ... > > Yes, these days we use info chardev, or query-chardev as appropriate > for the monitor mode. So do you want continue using query-chardev, or do you prefer to get the path returned directly, i.e. something like the attached patch? cheers, Gerd --------------080905030600090307070102 Content-Type: text/plain; name="0001-chardev-hotplug-qmp-pty.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-chardev-hotplug-qmp-pty.patch" RnJvbSBhNjE2YWU3M2Q1NDVhODBiM2E1NDVmZGM2NmJmMTQxYTliM2JhMDA0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNv bT4KRGF0ZTogVGh1LCAyMCBEZWMgMjAxMiAxNDozOToxMyArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIGNoYXJkZXY6IGhvdHBsdWcsIHFtcCwgcHR5CgpTaWduZWQtb2ZmLWJ5OiBHZXJkIEhv ZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KLS0tCiBxYXBpLXNjaGVtYS5qc29uIHwgICAg NyArKysrKystCiBxZW11LWNoYXIuYyAgICAgIHwgICAyNCArKysrKysrKysrKysrKysrKysr KystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9xYXBpLXNjaGVtYS5qc29uIGIvcWFwaS1zY2hlbWEuanNvbgpp bmRleCAzOWUwYWI0Li42M2M2MWM0IDEwMDY0NAotLS0gYS9xYXBpLXNjaGVtYS5qc29uCisr KyBiL3FhcGktc2NoZW1hLmpzb24KQEAgLTMwNTQsMTAgKzMwNTQsMTUgQEAKIHsgJ3VuaW9u JzogJ0NoYXJkZXZCYWNrZW5kJywgJ2RhdGEnOiB7ICdmaWxlJyAgIDogJ0NoYXJkZXZGaWxl JywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdwb3J0JyAgIDog J0NoYXJkZXZQb3J0JywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICdzb2NrZXQnIDogJ0NoYXJkZXZTb2NrZXQnLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJ3B0eScgICAgOiAnQ2hhcmRldkR1bW15JywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICdudWxsJyAgIDogJ0NoYXJkZXZEdW1teScg fSB9CiAKK3sgJ3VuaW9uJzogJ0NoYXJkZXZSZXR1cm4nLCAnZGF0YSc6IHsgJ3B0eScgICAg OiAnc3RyJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ25vZGF0 YScgOiAnQ2hhcmRldkR1bW15JyB9IH0KKwogeyAnY29tbWFuZCc6ICdjaGFyZGV2LWFkZCcs ICdkYXRhJzogeydpZCcgICAgICA6ICdzdHInLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICdiYWNrZW5kJyA6ICdDaGFyZGV2QmFja2VuZCcgfSB9CisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2JhY2tlbmQnIDogJ0NoYXJkZXZCYWNr ZW5kJyB9LAorICAncmV0dXJucycgOiAnQ2hhcmRldlJldHVybicgfQogCiAjIwogIyBAY2hh cmRldi1yZW1vdmU6CmRpZmYgLS1naXQgYS9xZW11LWNoYXIuYyBiL3FlbXUtY2hhci5jCmlu ZGV4IDkxMTY0OWEuLjdmNjVkNDAgMTAwNjQ0Ci0tLSBhL3FlbXUtY2hhci5jCisrKyBiL3Fl bXUtY2hhci5jCkBAIC0zMTE1LDkgKzMxMTUsMTMgQEAgc3RhdGljIENoYXJEcml2ZXJTdGF0 ZSAqcW1wX2NoYXJkZXZfb3Blbl9zb2NrZXQoQ2hhcmRldlNvY2tldCAqc29jaywKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXNfdGVsbmV0LCBpc193YWl0Y29ubmVj dCwgZXJycCk7CiB9CiAKLXZvaWQgcW1wX2NoYXJkZXZfYWRkKGNvbnN0IGNoYXIgKmlkLCBD aGFyZGV2QmFja2VuZCAqYmFja2VuZCwgRXJyb3IgKiplcnJwKQorQ2hhcmRldlJldHVybiAq cW1wX2NoYXJkZXZfYWRkKGNvbnN0IGNoYXIgKmlkLCBDaGFyZGV2QmFja2VuZCAqYmFja2Vu ZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBFcnJvciAqKmVycnApCiB7Ci0g ICAgQ2hhckRyaXZlclN0YXRlICpjaHI7CisgICAgQ2hhcmRldlJldHVybiAqcmV0ID0gZ19u ZXcwKENoYXJkZXZSZXR1cm4sIDEpOworICAgIENoYXJEcml2ZXJTdGF0ZSAqY2hyID0gTlVM TDsKKworICAgIHJldC0+a2luZCA9IENIQVJERVZfUkVUVVJOX0tJTkRfTk9EQVRBOwogCiAg ICAgc3dpdGNoIChiYWNrZW5kLT5raW5kKSB7CiAgICAgY2FzZSBDSEFSREVWX0JBQ0tFTkRf S0lORF9GSUxFOgpAQCAtMzEyOSwxNyArMzEzMywzMSBAQCB2b2lkIHFtcF9jaGFyZGV2X2Fk ZChjb25zdCBjaGFyICppZCwgQ2hhcmRldkJhY2tlbmQgKmJhY2tlbmQsIEVycm9yICoqZXJy cCkKICAgICBjYXNlIENIQVJERVZfQkFDS0VORF9LSU5EX1NPQ0tFVDoKICAgICAgICAgY2hy ID0gcW1wX2NoYXJkZXZfb3Blbl9zb2NrZXQoYmFja2VuZC0+c29ja2V0LCBlcnJwKTsKICAg ICAgICAgYnJlYWs7CisjaWZkZWYgSEFWRV9DSEFSREVWX1RUWQorICAgIGNhc2UgQ0hBUkRF Vl9CQUNLRU5EX0tJTkRfUFRZOgorICAgIHsKKyAgICAgICAgLyogcWVtdV9jaHJfb3Blbl9w dHkgc2V0cyAicGF0aCIgaW4gb3B0cyAqLworICAgICAgICBRZW11T3B0cyAqb3B0czsKKyAg ICAgICAgb3B0cyA9IHFlbXVfb3B0c19jcmVhdGVfbm9mYWlsKHFlbXVfZmluZF9vcHRzKCJj aGFyZGV2IikpOworICAgICAgICBjaHIgPSBxZW11X2Nocl9vcGVuX3B0eShvcHRzKTsKKyAg ICAgICAgcmV0LT5raW5kID0gQ0hBUkRFVl9SRVRVUk5fS0lORF9QVFk7CisgICAgICAgIHJl dC0+cHR5ID0gZ19zdHJkdXAocWVtdV9vcHRfZ2V0KG9wdHMsICJwYXRoIikpOworICAgICAg ICBxZW11X29wdHNfZGVsKG9wdHMpOworICAgICAgICBicmVhazsKKyAgICB9CisjZW5kaWYK ICAgICBjYXNlIENIQVJERVZfQkFDS0VORF9LSU5EX05VTEw6CiAgICAgICAgIGNociA9IHFl bXVfY2hyX29wZW5fbnVsbChOVUxMKTsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoK ICAgICAgICAgZXJyb3Jfc2V0ZyhlcnJwLCAidW5rbm93biBjaGFyZGV2IGJhY2tlbmQgKCVk KSIsIGJhY2tlbmQtPmtpbmQpOwotICAgICAgICByZXR1cm47CisgICAgICAgIGJyZWFrOwog ICAgIH0KIAogICAgIGlmIChjaHIgPT0gTlVMTCAmJiAhZXJyb3JfaXNfc2V0KGVycnApKSB7 CiAgICAgICAgIGVycm9yX3NldGcoZXJycCwgIkZhaWxlZCB0byBjcmVhdGUgY2hhcmRldiIp OwogICAgIH0KKyAgICByZXR1cm4gcmV0OwogfQogCiB2b2lkIHFtcF9jaGFyZGV2X3JlbW92 ZShjb25zdCBjaGFyICppZCwgRXJyb3IgKiplcnJwKQotLSAKMS43LjEKCg== --------------080905030600090307070102--