From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm3ZO-0007v1-L9 for qemu-devel@nongnu.org; Fri, 21 Dec 2012 09:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm3ZM-0004Wv-Iq for qemu-devel@nongnu.org; Fri, 21 Dec 2012 09:27:26 -0500 Received: from mail-ia0-f177.google.com ([209.85.210.177]:44343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm3ZM-0004Wr-EM for qemu-devel@nongnu.org; Fri, 21 Dec 2012 09:27:24 -0500 Received: by mail-ia0-f177.google.com with SMTP id u21so3857999ial.8 for ; Fri, 21 Dec 2012 06:27:23 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50D471C6.7000105@redhat.com> Date: Fri, 21 Dec 2012 15:27:18 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1356044532-8511-1-git-send-email-quintela@redhat.com> <87ehikmeqj.fsf@codemonkey.ws> In-Reply-To: <87ehikmeqj.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/34] migration thread and queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Juan Quintela Il 21/12/2012 01:27, Anthony Liguori ha scritto: > #!/bin/sh > > gzip -d -c lidb.ssmall.img.gz | \ > ~/build/qemu/x86_64-softmmu/qemu-system-x86_64 -cdrom \ > ~/isos/OCDC-lucid-Test-Drive-20110523_140333.iso -enable-kvm -m 2G \ > -incoming exec:dd > > With lidb.ssmall.img.gz being generated from a 'migrate exec:dd of=...' > from qemu.git just a week or two ago. So it breaks *incoming* migration, which would restrict the problem to the beginning of the patch (reorganization of the RAM block list). Everything else touches only outgoing migration. However, I tested bidirectional migration between origin/master and Juan's branch and it passed x86_64-softmmu/qemu-system-x86_64 \ -drive if=virtio,cache=none,file=/../images/jeos-17-64.qcow2 \ -vnc :1 -incoming "exec:cat foo" --enable-kvm I also tested both my and Juan's branches and they both pass all migration tests. > I can't bisect tonight but can attempt to tomorrow. How has this been > tested? Indeed old->new and new->old migration wasn't tested AFAIK. Not by me at least. Paolo > I'm a little concerned here about the timing. With the Christmas > and New Years holiday we're pretty darn close to soft freeze for 1.4. > > Has this series gone through a full autotest run with multiple guests?