From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command
Date: Fri, 21 Dec 2012 11:17:27 -0700 [thread overview]
Message-ID: <50D4A7B7.2060708@redhat.com> (raw)
In-Reply-To: <87vcbv1mvu.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On 12/21/2012 07:49 AM, Markus Armbruster wrote:
>>> +static const mon_cmd_t *monitor_parse_command(Monitor *mon,
>>> + const char *cmdline,
>>> + const mon_cmd_t *table,
>>> + QDict *qdict);
>>
>> Please, move the function instead.
>
> Move will make review harder. I don't mind forward declarations.
If you do move the function, then split this into two patches - one for
JUST the code motion, and another that adds the 'table' argument to the
function.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2012-12-21 18:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 10:17 [Qemu-devel] [PATCH 0/3] HMP: enable info sub command taking parameter Wenchao Xia
2012-12-19 10:17 ` [Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler Wenchao Xia
2012-12-21 14:01 ` Markus Armbruster
2012-12-25 2:52 ` Wenchao Xia
2012-12-19 10:17 ` [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command Wenchao Xia
2012-12-19 18:07 ` Luiz Capitulino
2012-12-20 3:02 ` Wenchao Xia
2012-12-22 21:36 ` Luiz Capitulino
2012-12-21 14:49 ` Markus Armbruster
2012-12-21 18:17 ` Eric Blake [this message]
2012-12-25 4:29 ` Wenchao Xia
2012-12-19 10:17 ` [Qemu-devel] [PATCH 3/3] HMP: show internal snapshots on a single device Wenchao Xia
2012-12-21 14:07 ` Markus Armbruster
2012-12-25 3:11 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D4A7B7.2060708@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).