From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm7AE-0003RS-Ph for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:17:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm7A9-00029q-Bt for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:17:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm7A9-00029i-2N for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:17:37 -0500 Message-ID: <50D4A7B7.2060708@redhat.com> Date: Fri, 21 Dec 2012 11:17:27 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355912230-25132-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1355912230-25132-3-git-send-email-xiawenc@linux.vnet.ibm.com> <20121219160743.34cdfd73@doriath.home> <87vcbv1mvu.fsf@blackfin.pond.sub.org> In-Reply-To: <87vcbv1mvu.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigEB1BEF791DE293945AFF8CE4" Subject: Re: [Qemu-devel] [PATCH 2/3] HMP: pass in parameter for info sub command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, Luiz Capitulino , pbonzini@redhat.com, Wenchao Xia This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEB1BEF791DE293945AFF8CE4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/21/2012 07:49 AM, Markus Armbruster wrote: >>> +static const mon_cmd_t *monitor_parse_command(Monitor *mon, >>> + const char *cmdline, >>> + const mon_cmd_t *table= , >>> + QDict *qdict); >> >> Please, move the function instead. >=20 > Move will make review harder. I don't mind forward declarations. If you do move the function, then split this into two patches - one for JUST the code motion, and another that adds the 'table' argument to the function. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigEB1BEF791DE293945AFF8CE4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ1Ke3AAoJEKeha0olJ0NqgiAH/iJvsH5ZQoYciswJqKjtczfi MhcK8XU7glMOT/tp1xlSctSP5Pzl/4cDlKVWfViAkpBSIxltZqtaV3ADiWnf/ah6 3D3SN0bQbjCSVPLgJtH1q83UPLXS/wFvMn9NFgd98GAydXIKZWT0J9Nl2HLcp9ex GepbYGtX0bSQ67nSF3V8iK2nc4M1hw0yI8EZfboaT2MPzhUFPj6SwAQw/DBEvZNr yWqkB6LVIt0SumtxNi1eM9BYV5uuuUyzsnsXUudilhuAGhB8QlGlKuyFQXeaYhKW tyvqJXlUUeepEs317p/ijGdXsAIVVBXzu6WCXrrImdBb0UA3OPDrRSuLQbp2cbg= =Mwj4 -----END PGP SIGNATURE----- --------------enigEB1BEF791DE293945AFF8CE4--