From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm7Zm-0002bg-FG for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:44:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tm7Zf-0000Md-Vo for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:44:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tm7Zf-0000MR-Nh for qemu-devel@nongnu.org; Fri, 21 Dec 2012 13:43:59 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBLIhwpD009563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Dec 2012 13:43:58 -0500 Message-ID: <50D4ADEB.3060205@redhat.com> Date: Fri, 21 Dec 2012 11:43:55 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig01FCBEB902B7807A1233CC4F" Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Extend guest-network-get-interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig01FCBEB902B7807A1233CC4F Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/21/2012 05:59 AM, Michal Privoznik wrote: > Nowadays only basic information is reported. However, with the > current implementation much more can be exposed to users. like > broadcast/destination address (the former in case of standard > ethernet device, the latter in case of PPP interface), if the > interface is up, of type loopback, in promisc mode or capable of > sending multicast. > --- >=20 > +++ b/qga/qapi-schema.json > @@ -480,26 +480,57 @@ > # > # @prefix: Network prefix length of @ip-address > # > -# Since: 1.1 > +# @dest-address: The broadcast or peer address. > +# > +# Since: 1.1, @dest-address since 1.3 Actually, since 1.4 now (1.3 is already out). > ## > { 'type': 'GuestIpAddress', > 'data': {'ip-address': 'str', > 'ip-address-type': 'GuestIpAddressType', > - 'prefix': 'int'} } > + 'prefix': 'int', > + '*dest-address': 'str'} } Is this field always going to be present in 1.4? If so, then it doesn't need to be marked optional (even though it wasn't present in 1.3). > ## > +# @GuestNetworkInterfaceType: > +# > +# @broadcast: Interface has a broadcast address. In which case it is > +# contained in @dest-address in @GuestIpAddress. > +# > +# @ppp: Interface is of point-to-point type. The peer address is then = in > +# @dest-address in @GuestIpAddress. > +# > +# Since: 1.3 1.4 > +## > +{ 'enum': 'GuestNetworkInterfaceType', > + 'data': ['broadcast', 'ppp'] } > +## > # @GuestNetworkInterface: > # > # @name: The name of interface for which info are being delivered > # > +# @up: If the interface is up > +# > +# @loopback: If the interface is of loopback type > +# > +# @promisc: If the interface is in promiscuous mode > +# > +# @multicast: If the interface is cappable of multicast s/cappable/capable/ > +# > +# @type: If the interface has a broadcast address(-es) assigned, or is= a PPP. > +# > # @hardware-address: Hardware address of @name > # > # @ip-addresses: List of addresses assigned to @name > # > -# Since: 1.1 > +# Since: 1.1, @up, @loopback, @promisc, @multicast and @type since 1.3= 1.4 > ## > { 'type': 'GuestNetworkInterface', > 'data': {'name': 'str', > + 'up': 'bool', > + 'loopback': 'bool', > + 'promisc': 'bool', > + 'multicast': 'bool', > + '*type': 'GuestNetworkInterfaceType', Again, is this field optional? > '*hardware-address': 'str', > '*ip-addresses': ['GuestIpAddress'] } } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig01FCBEB902B7807A1233CC4F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ1K3sAAoJEKeha0olJ0Nq/hAH/j6VySYIBzF2mZk84MG2e3kL 90sOQbUYZExmP6wXy7nqFQZxVvxH/wGzbXS+BoI3406L2Rcmh1I5bdCqkxKYl4Uw pmQNtRJRMsC/+rKU8lDl27vcyhwF737NBMvCguh1+tm5eGLlgpzmc4buGaselxWr nXD+mY4qNqje+cfztdwukLQMugkRN78RJvQsvOLZfOvKY1TxHCkZ6I5AI3zyTkNz GkV5wwJ6MmtKCJzlDrEpaojMtUysHBxl5GkLMgQI1wqceb5jdp++lJEVVpNDKiVx OiKuJ//dBZBzFOhIQgD/ECGpUvnAdyM8PDBWMt0OBZnPcjzlKfWi/WIas6wEsNo= =qkFq -----END PGP SIGNATURE----- --------------enig01FCBEB902B7807A1233CC4F--