From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnMB4-00060C-54 for qemu-devel@nongnu.org; Mon, 24 Dec 2012 23:31:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TnMB0-0005Vj-6E for qemu-devel@nongnu.org; Mon, 24 Dec 2012 23:31:42 -0500 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:60677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnMAz-0005VT-Ir for qemu-devel@nongnu.org; Mon, 24 Dec 2012 23:31:38 -0500 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Dec 2012 14:27:11 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 79A3E3578023 for ; Tue, 25 Dec 2012 15:31:31 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBP4KARe60096760 for ; Tue, 25 Dec 2012 15:20:10 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBP4VUnP005530 for ; Tue, 25 Dec 2012 15:31:30 +1100 Message-ID: <50D92C1B.2040003@linux.vnet.ibm.com> Date: Tue, 25 Dec 2012 12:31:23 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1355725509-5429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1355725509-5429-2-git-send-email-xiawenc@linux.vnet.ibm.com> <87ip7vl1eb.fsf@elfo.mitica> In-Reply-To: <87ip7vl1eb.fsf@elfo.mitica> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com ÓÚ 2012-12-22 2:13, Juan Quintela дµÀ: > Wenchao Xia wrote: >> This patch moves bdrv_snapshotfind from savevm.c to block.c and export >> it, also added bdrv_deappend in block.c. > > I think this patch can be splitted in two: > - new bdv_deappend > - move bdrv_snapshot_find > OK. -- Best Regards Wenchao Xia