From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnN09-0005Kh-Ls for qemu-devel@nongnu.org; Tue, 25 Dec 2012 00:24:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TnN08-00089F-EP for qemu-devel@nongnu.org; Tue, 25 Dec 2012 00:24:29 -0500 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:48142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnN07-000896-RI for qemu-devel@nongnu.org; Tue, 25 Dec 2012 00:24:28 -0500 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Dec 2012 10:53:34 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 8381C125804C for ; Tue, 25 Dec 2012 10:54:23 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBP5OKpT47644924 for ; Tue, 25 Dec 2012 10:54:21 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBP5OLZK006475 for ; Tue, 25 Dec 2012 16:24:21 +1100 Message-ID: <50D9387D.9060301@linux.vnet.ibm.com> Date: Tue, 25 Dec 2012 13:24:13 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1355725509-5429-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1355725509-5429-4-git-send-email-xiawenc@linux.vnet.ibm.com> <87y5grjl5k.fsf@elfo.mitica> In-Reply-To: <87y5grjl5k.fsf@elfo.mitica> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com ÓÚ 2012-12-22 2:49, Juan Quintela дµÀ: > Wenchao Xia wrote: >> + >> +typedef struct SNTime { >> + uint32_t date_sec; /* UTC date of the snapshot */ >> + uint32_t date_nsec; > > This two fields are just struct timespec, does it makes sense to use it? > make sense, I did not notice timespec before, will use it if windows support timespec too. >> + >> +/* Core structure for group snapshots, fill in it and then call the API. */ >> +typedef struct BlkTransactionStates BlkTransactionStates; >> + >> +struct BlkTransactionStates { >> + /* caller input */ >> + bool async; > > Why do we have this variable? As far as I can see, we only test its > value, and set it to false. Are we missing any patch? > No, I just put it here as a reserved option. Maybe live block commit can be considered as async deletion of snapshot, but nevermind I'll delete it for that it is not supported now. -- Best Regards Wenchao Xia