From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tnply-0005ES-Na for qemu-devel@nongnu.org; Wed, 26 Dec 2012 07:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tnplx-0007QD-1O for qemu-devel@nongnu.org; Wed, 26 Dec 2012 07:07:46 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:57913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tnplw-0007Q1-Mw for qemu-devel@nongnu.org; Wed, 26 Dec 2012 07:07:44 -0500 Message-ID: <50DAE896.8080600@rdsoftware.de> Date: Wed, 26 Dec 2012 13:07:50 +0100 From: Erik Rull MIME-Version: 1.0 References: <1354702284-13518-1-git-send-email-kraxel@redhat.com> <1354702284-13518-7-git-send-email-kraxel@redhat.com> In-Reply-To: <1354702284-13518-7-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] usb-tablet: Allow connecting to ehci List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Hans de Goede , qemu-devel@nongnu.org Hi Gerd, hi Hans, is my assumption correct that if I check out and compile this version from GIT master that the usb-tablet device is automatically routed to ehci without changing anything else in the qemu call arguments? (And the performance enhancement takes place automatically) If not - what has to be changed to get it working? Best regards, Erik Gerd Hoffmann wrote: > From: Hans de Goede > > Our ehci code has is capable of significantly lowering the wakeup rate > for the hcd emulation while the device is idle. It is possible to add > similar code ot the uhci emulation, but that simply is not there atm, > and there is no reason why a (virtual) usb-tablet can not be a USB-2 device. > > Making usb-hid devices connect to the emulated ehci controller instead > of the emulated uhci controller on vms which have both lowers the cpuload > for a fully idle vm from 20% to 2-3% (on my laptop). > > An alternative implementation to using a property to select the tablet > type, would be simply making it a new device type, ie usb-tablet2, but the > downside of that is that this will require libvirt changes to be available > through libvirt at all, and then management tools changes to become the > default for new vms, where as using a property will automatically get > any pc-1.3 type vms the lower cpuload. > > [ kraxel: adapt compat property for post-1.3 merge ] > > Signed-off-by: Hans de Goede > Signed-off-by: Gerd Hoffmann > > tablet compat fixup > > Signed-off-by: Gerd Hoffmann