From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To9rT-0004MG-Lj for qemu-devel@nongnu.org; Thu, 27 Dec 2012 04:34:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1To9rS-0004wx-BQ for qemu-devel@nongnu.org; Thu, 27 Dec 2012 04:34:47 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:33674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To9rR-0004vz-J1 for qemu-devel@nongnu.org; Thu, 27 Dec 2012 04:34:46 -0500 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Dec 2012 19:27:48 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 66C3B3578023 for ; Thu, 27 Dec 2012 20:34:36 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBR9NLOL1704354 for ; Thu, 27 Dec 2012 20:23:21 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBR9YZ5E007604 for ; Thu, 27 Dec 2012 20:34:35 +1100 Message-ID: <50DC161A.3090000@linux.vnet.ibm.com> Date: Thu, 27 Dec 2012 17:34:18 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1356598589-5744-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1356598589-5744-2-git-send-email-xiawenc@linux.vnet.ibm.com> <20121227090355.GB85692@cs.nctu.edu.tw> In-Reply-To: <20121227090355.GB85692@cs.nctu.edu.tw> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 1/3] HMP: add QDict to info callback handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?IumZs+mfi+S7uyAoV2VpLVJlbiBDaGVuKSI=?= Cc: pbonzini@redhat.com, aliguori@us.ibm.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com > On Thu, Dec 27, 2012 at 04:56:27PM +0800, Wenchao Xia wrote: >> This patch change all info call back function to take >> additional QDict * parameter, which allow those command >> take parameter. Now it is set to NULL at default case. >> >> v2: rebased, and better doc. >> >> Signed-off-by: Wenchao Xia >> --- > > I remember the change log should be put here, right? > I used to put changelog in commit message, let me resend it. >> hmp.c | 36 ++++++++++++++++++------------------ >> hmp.h | 36 ++++++++++++++++++------------------ >> hw/i8259.c | 4 ++-- >> hw/lm32_pic.c | 4 ++-- >> hw/lm32_pic.h | 4 ++-- -- Best Regards Wenchao Xia