From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To9wy-00067I-UZ for qemu-devel@nongnu.org; Thu, 27 Dec 2012 04:40:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1To9wx-0006c6-UM for qemu-devel@nongnu.org; Thu, 27 Dec 2012 04:40:28 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:47794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1To9wx-0006a6-8d for qemu-devel@nongnu.org; Thu, 27 Dec 2012 04:40:27 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Dec 2012 19:39:03 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 6725C2CE804A for ; Thu, 27 Dec 2012 20:40:20 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qBR9eJ2265536030 for ; Thu, 27 Dec 2012 20:40:19 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qBR9eIWq013935 for ; Thu, 27 Dec 2012 20:40:19 +1100 Message-ID: <50DC1761.6010400@linux.vnet.ibm.com> Date: Thu, 27 Dec 2012 17:39:45 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1356598589-5744-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1356598589-5744-2-git-send-email-xiawenc@linux.vnet.ibm.com> <20121227090355.GB85692@cs.nctu.edu.tw> <50DC161A.3090000@linux.vnet.ibm.com> In-Reply-To: <50DC161A.3090000@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 1/3] HMP: add QDict to info callback handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?IumZs+mfi+S7uyAoV2VpLVJlbiBDaGVuKSI=?= Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com Sorry I forgot to change the version number, pls ignore this serial. > > On Thu, Dec 27, 2012 at 04:56:27PM +0800, Wenchao Xia wrote: >>> This patch change all info call back function to take >>> additional QDict * parameter, which allow those command >>> take parameter. Now it is set to NULL at default case. >>> >>> v2: rebased, and better doc. >>> >>> Signed-off-by: Wenchao Xia >>> --- >> >> I remember the change log should be put here, right? >> > I used to put changelog in commit message, let me resend it. > >>> hmp.c | 36 ++++++++++++++++++------------------ >>> hmp.h | 36 ++++++++++++++++++------------------ >>> hw/i8259.c | 4 ++-- >>> hw/lm32_pic.c | 4 ++-- >>> hw/lm32_pic.h | 4 ++-- > > > -- Best Regards Wenchao Xia