qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Bug 1087114 <1087114@bugs.launchpad.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed
Date: Thu, 27 Dec 2012 12:48:56 +0100	[thread overview]
Message-ID: <50DC35A8.201@redhat.com> (raw)
In-Reply-To: <20121227042700.26057.92281.malone@soybean.canonical.com>

Il 27/12/2012 05:26, Brad Smith ha scritto:
> Paolo,
> 
> As you wrote the fallback code which is used when sem_timedwait() is
> missing could you please take a look at this when you have some time? I
> can test any patches you might come up with.

Can you try this:

diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index 7be292e..17f2d7c 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -213,6 +213,7 @@ int qemu_sem_timedwait(QemuSemaphore *sem, int ms)
     while (sem->count < 0) {
         rc = pthread_cond_timedwait(&sem->cond, &sem->lock, &ts);
         if (rc == ETIMEDOUT) {
+            ++sem->count;
             break;
         }
         if (rc != 0) {

and if it passes, post it?  I'll be very sparsely online until Jan 8th.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

  reply	other threads:[~2012-12-27 11:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  4:02 [Qemu-devel] [Bug 1087114] [NEW] assertion "QLIST_EMPTY(&bs->tracked_requests)" failed Brad Smith
2012-12-11 10:28 ` Stefan Hajnoczi
2012-12-12 18:10 ` [Qemu-devel] [Bug 1087114] " Brad Smith
2012-12-13  8:26 ` [Qemu-devel] [Bug 1087114] [NEW] " Zhi Yong Wu
2012-12-27  4:22   ` Brad Smith
2012-12-13  9:39 ` [Qemu-devel] [Bug 1087114] " Paolo Bonzini
2012-12-13 10:16 ` Brad Smith
2012-12-13 22:37 ` Brad Smith
2012-12-27  4:26 ` Brad Smith
2012-12-27 11:48   ` Paolo Bonzini [this message]
2013-01-12  5:15 ` Austin Seipp
2013-01-14  9:28   ` Markus Armbruster
2013-01-12 12:48 ` Aaron
2013-01-12 21:51 ` Rainer Müller
2013-01-13 12:22 ` Aaron Jackson
2013-01-17 12:46 ` Brad Smith
2013-01-17 12:49 ` Brad Smith
2013-01-17 14:00 ` Aaron Jackson
2013-01-17 14:36 ` Rainer Müller
2013-03-19  2:07 ` Brad Smith
2013-07-01  1:12 ` Brad Smith
2013-08-05 21:08 ` Brad Smith
2013-08-11 12:30 ` Rainer Müller
2016-09-28 15:21 ` T. Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DC35A8.201@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=1087114@bugs.launchpad.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).