From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TohzC-0003T5-7s for qemu-devel@nongnu.org; Fri, 28 Dec 2012 17:01:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tohz9-0000yQ-Mh for qemu-devel@nongnu.org; Fri, 28 Dec 2012 17:01:02 -0500 Received: from mail-pb0-f54.google.com ([209.85.160.54]:46342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tohz9-0000yC-GV for qemu-devel@nongnu.org; Fri, 28 Dec 2012 17:00:59 -0500 Received: by mail-pb0-f54.google.com with SMTP id wz12so6086571pbc.13 for ; Fri, 28 Dec 2012 14:00:58 -0800 (PST) Sender: Richard Henderson Message-ID: <50DE1698.20305@twiddle.net> Date: Fri, 28 Dec 2012 14:00:56 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1354914437-15967-1-git-send-email-rth@twiddle.net> In-Reply-To: <1354914437-15967-1-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] tcg: Add TCGV_IS_UNUSED_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Aurelien Jarno Ping 2. There is a Reviewed-by... r~ On 2012-12-07 13:07, Richard Henderson wrote: > Cc: Aurelien Jarno > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h | 2 ++ > tcg/tcg.h | 3 +++ > 2 files changed, 5 insertions(+) > > Changes since v1: > * Add tl-sized TCGV_IS_UNUSED to tcg-op.h. > > > r~ > > > diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h > index 0b3cb0b..91c9d80 100644 > --- a/tcg/tcg-op.h > +++ b/tcg/tcg-op.h > @@ -2329,6 +2329,7 @@ static inline void tcg_gen_movcond_i64(TCGCond cond, TCGv_i64 ret, > #define tcg_gen_qemu_ldst_op tcg_gen_op3i_i32 > #define tcg_gen_qemu_ldst_op_i64 tcg_gen_qemu_ldst_op_i64_i32 > #define TCGV_UNUSED(x) TCGV_UNUSED_I32(x) > +#define TCGV_IS_UNUSED(x) TCGV_IS_UNUSED_I32(x) > #define TCGV_EQUAL(a, b) TCGV_EQUAL_I32(a, b) > #else > #define TCGv TCGv_i64 > @@ -2340,6 +2341,7 @@ static inline void tcg_gen_movcond_i64(TCGCond cond, TCGv_i64 ret, > #define tcg_gen_qemu_ldst_op tcg_gen_op3i_i64 > #define tcg_gen_qemu_ldst_op_i64 tcg_gen_qemu_ldst_op_i64_i64 > #define TCGV_UNUSED(x) TCGV_UNUSED_I64(x) > +#define TCGV_IS_UNUSED(x) TCGV_IS_UNUSED_I64(x) > #define TCGV_EQUAL(a, b) TCGV_EQUAL_I64(a, b) > #endif > > diff --git a/tcg/tcg.h b/tcg/tcg.h > index 9481e35..90406fc 100644 > --- a/tcg/tcg.h > +++ b/tcg/tcg.h > @@ -270,6 +270,9 @@ typedef int TCGv_i64; > #define TCGV_UNUSED_I32(x) x = MAKE_TCGV_I32(-1) > #define TCGV_UNUSED_I64(x) x = MAKE_TCGV_I64(-1) > > +#define TCGV_IS_UNUSED_I32(x) (GET_TCGV_I32(x) == -1) > +#define TCGV_IS_UNUSED_I64(x) (GET_TCGV_I64(x) == -1) > + > /* call flags */ > /* Helper does not read globals (either directly or through an exception). It > implies TCG_CALL_NO_WRITE_GLOBALS. */ >