* [Qemu-devel] [PATCH] tcg: Remove unneeded assertion
@ 2012-12-30 7:20 Stefan Weil
2012-12-31 18:12 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2012-12-30 7:20 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
Commit 7f6f0ae5b95adfa76e10eabe2c34424a955fd10c added two assertions.
One of these assertions is not needed:
The pointer ts is never NULL because it is initialized with the
address of an array element.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tcg/tcg.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index ede51a3..9275e37 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -800,7 +800,6 @@ static char *tcg_get_arg_str_idx(TCGContext *s, char *buf, int buf_size,
assert(idx >= 0 && idx < s->nb_temps);
ts = &s->temps[idx];
- assert(ts);
if (idx < s->nb_globals) {
pstrcpy(buf, buf_size, ts->name);
} else {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: Remove unneeded assertion
2012-12-30 7:20 [Qemu-devel] [PATCH] tcg: Remove unneeded assertion Stefan Weil
@ 2012-12-31 18:12 ` Richard Henderson
0 siblings, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2012-12-31 18:12 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On 2012-12-29 23:20, Stefan Weil wrote:
> Commit 7f6f0ae5b95adfa76e10eabe2c34424a955fd10c added two assertions.
>
> One of these assertions is not needed:
> The pointer ts is never NULL because it is initialized with the
> address of an array element.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tcg: Remove unneeded assertion
@ 2013-01-03 2:21 Anthony Liguori
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2013-01-03 2:21 UTC (permalink / raw)
To: Stefan Weil, qemu-trivial; +Cc: qemu-devel
Thanks, applied.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-02 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-30 7:20 [Qemu-devel] [PATCH] tcg: Remove unneeded assertion Stefan Weil
2012-12-31 18:12 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2013-01-03 2:21 Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).