From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqOgM-0002Hu-TZ for qemu-devel@nongnu.org; Wed, 02 Jan 2013 08:49:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqOg2-0007DG-8P for qemu-devel@nongnu.org; Wed, 02 Jan 2013 08:48:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51749 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqOg2-0007Bl-0q for qemu-devel@nongnu.org; Wed, 02 Jan 2013 08:48:14 -0500 Message-ID: <50E43A90.7010507@suse.de> Date: Wed, 02 Jan 2013 14:48:00 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1354726153-30264-1-git-send-email-ehabkost@redhat.com> <1354726153-30264-2-git-send-email-ehabkost@redhat.com> <50CB4705.80609@suse.de> <20121214172118.GC17653@otherpad.lan.raisama.net> In-Reply-To: <20121214172118.GC17653@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Don Slutz , qemu-devel@nongnu.org, Igor Mammedov Am 14.12.2012 18:21, schrieb Eduardo Habkost: > On Fri, Dec 14, 2012 at 04:34:29PM +0100, Andreas F=E4rber wrote: >> Waiting for ack or nack from Paolo here. I am expecting some overlap >> with his header file reorganization series. >> >> My previous (unanswered?) question was why you are moving vl.o lines i= n >> addition to the QEMU_CFLAGS lines that you mention in the commit messa= ge. >=20 >=20 > I thought this note in the commit message would answer the question: >=20 >>> This also moves the existing CFLAGS lines from Makefile.objs at the >>> beginning of the file, to keep them all in the same place. >=20 > In other words: it's cosmetic, just to keep all the QEMU_CLFAGS lines > inside Makefile.objs grouped in a visible place at the beginning of the > file. >=20 > (You noticed that I am moving the vl.o lines _inside_ Makefile.obj, > right? They are not being moved between different files.) Nah, you caught me there, must've misread that on a previous submission (or it changed or whatever). Anyway, Paolo's header reorganization was pulled by now, so this patch no longer seems necessary, series compiles without. Please shout if I'm misreading this! Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg