From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqPLG-0007yx-QH for qemu-devel@nongnu.org; Wed, 02 Jan 2013 09:30:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqPLE-0002aT-83 for qemu-devel@nongnu.org; Wed, 02 Jan 2013 09:30:50 -0500 Received: from greensocs.com ([87.106.252.221]:55474 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqPLD-0002aN-Vz for qemu-devel@nongnu.org; Wed, 02 Jan 2013 09:30:48 -0500 Message-ID: <50E44492.7060902@greensocs.com> Date: Wed, 02 Jan 2013 15:30:42 +0100 From: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= MIME-Version: 1.0 References: <1355910821-21302-1-git-send-email-fred.konrad@greensocs.com> <1355910821-21302-2-git-send-email-fred.konrad@greensocs.com> <87obh7d6el.fsf@codemonkey.ws> <50E44132.1020309@suse.de> In-Reply-To: <50E44132.1020309@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, Anthony Liguori , e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, stefanha@redhat.com, cornelia.huck@de.ibm.com On 02/01/2013 15:16, Andreas F=E4rber wrote: > Am 02.01.2013 15:08, schrieb Anthony Liguori: >> fred.konrad@greensocs.com writes: >> >>> From: KONRAD Frederic >>> >>> Add a max_dev field to BusState to specify the maximum amount of devi= ces allowed >>> on the bus ( have no effect if max_dev=3D0 ) >>> >>> Signed-off-by: KONRAD Frederic >>> --- >>> hw/qdev-core.h | 2 ++ >>> hw/qdev-monitor.c | 11 +++++++++++ >>> 2 files changed, 13 insertions(+) >>> >>> diff --git a/hw/qdev-core.h b/hw/qdev-core.h >>> index d672cca..af909b9 100644 >>> --- a/hw/qdev-core.h >>> +++ b/hw/qdev-core.h >>> @@ -104,6 +104,8 @@ struct BusState { >>> const char *name; >>> int allow_hotplug; >>> int max_index; >>> + /* maximum devices allowed on the bus, 0 : no limit. */ >>> + int max_dev; > Can't for the virtio-bus case (which this is for AFAIU) the same effect > be achieved by setting max_index? If not, this could use some more > documentation - btw using gtk-doc style comments (above struct) would b= e > a bonus. no, max_index is just a variable which count the number of bus children=20 I think. max_index is incremented each time bus_add_child is called. maybe the name max_index is not a good choice ? > > Regards, > Andreas > > P.S. Please remember to use English punctuation rules, i.e. no spaces > before colon or inside parenthesis. ;) :s sorry for that. >