From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqROT-0004WD-If for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:42:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqROP-0004Xj-E2 for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:42:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqROP-0004XZ-6V for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:42:13 -0500 Message-ID: <50E4635E.60605@redhat.com> Date: Wed, 02 Jan 2013 09:42:06 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357143393-29832-1-git-send-email-benoit@irqsave.net> <1357143393-29832-31-git-send-email-benoit@irqsave.net> In-Reply-To: <1357143393-29832-31-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB4D24D78CC7F4845A662F94B" Subject: Re: [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB4D24D78CC7F4845A662F94B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/02/2013 09:16 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > tests/qemu-iotests/common.rc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.r= c > index aef5f52..72e746d 100644 > --- a/tests/qemu-iotests/common.rc > +++ b/tests/qemu-iotests/common.rc > @@ -124,7 +124,8 @@ _make_test_img() > -e "s# compat=3D'[^']*'##g" \ > -e "s# compat6=3D\\(on\\|off\\)##g" \ > -e "s# static=3D\\(on\\|off\\)##g" \ > - -e "s# lazy_refcounts=3D\\(on\\|off\\)##g" > + -e "s# lazy_refcounts=3D\\(on\\|off\\)##g" \ > + -e "s# dedup=3D\\('sha256'\\|'skein'\\|'sha3'\\)##g" Shouldn't this patch be hoisted earlier into the series, or even squashed in with the patch that introduced the temporary test failures? That is, you want 'git bisect' to pass on every patch in the series, rather than introducing problems in one patch that only get cleaned up in a later patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB4D24D78CC7F4845A662F94B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ5GNeAAoJEKeha0olJ0NqMZAIAKeT5SKZ7RYuszJxKlChyznN tHk3ljkgv6wiO6W6EPGzLBahoNmAB38w7o+ZHcP6jTNY8i2WOvXOcn42/S5M6Zm4 BN1QoqOmKsA/F8jSXMY4eehvF15VBNSM6jtS0vOS/CUCJwetmdkAEbb5kAZu4dRH M6NzxAbnN/N+kXxhfzvQQmcYbYAZEx+qY/A6W0Q3EsLeiBJU6LoxrkNzsHr87zMQ VQaJhgAfDM9/qG+IH2TK6IwWYYdpVbr54QqzbE4Fl/lJlooae7+CxhYO8h4O37dC htt1hFKVFZOD7662WRkRXq5jGLrW/gZiZqR0Khkh2zESEW7thdwyQvXGeIGh2AQ= =ZfB2 -----END PGP SIGNATURE----- --------------enigB4D24D78CC7F4845A662F94B--