From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqfeR-0004Oe-3Y for qemu-devel@nongnu.org; Thu, 03 Jan 2013 02:55:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqfeP-0006Hx-MF for qemu-devel@nongnu.org; Thu, 03 Jan 2013 02:55:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqfeP-0006HC-Er for qemu-devel@nongnu.org; Thu, 03 Jan 2013 02:55:41 -0500 Message-ID: <50E5396E.9070703@redhat.com> Date: Thu, 03 Jan 2013 08:55:26 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <466983004.47092829.1355395217322.JavaMail.root@redhat.com> <50C9E697.6040802@redhat.com> <50C9E9A2.7090102@redhat.com> <20121223203339.GC7485@garlic> In-Reply-To: <20121223203339.GC7485@garlic> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: Uri Lublin , =?ISO-8859-1?Q?S=F8ren_Sandmann?= , Yonit Halperin , qemu-devel@nongnu.org, Arnon Gilboa On 12/23/12 21:33, Alon Levy wrote: > On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>>> That is indeed a better solution, but it does change functionality. I >>>> think it is correct but I'd like to get some other opinions - Uri, >>>> Arnon, Yonit, Soren - any problems with dropping these? >>>> >>> Orientation is used in the Windows Display driver. It is used to set >>> dmDisplayOrientation in DEVMODEW structure >>> (http://msdn.microsoft.com/en-us/library/windows/hardware/ff552837(v=vs.85).aspx). >> >> What is supposed to happen in case the guest picks a mode with >> orientation != 0? >> >>> So, I'm not sure we can just drop it. Moreover, we need at least 2 of >>> the orientations, one for AxB resolution and the other for BxA. >> >> How do I switch a windows guest into 600x800? > > AFAIR it is just another mode that appears in the mode list, i.e. when > enumerating the modes via the windows API or via the GUI. That doesn't answer the questions How do I switch winxp (or any other guest) into 600x800, with orientation == 1 (or 3)? Display Properties offer 800x600 only. What is supposed to happen with orientation != 0? orientation isn't used anywhere in qxl. I'm pretty sure spice client doesn't know the windows guest uses a orientation != 0 and thus will not display the screen correctly. cheers, Gerd