From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Uri Lublin <uril@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque
Date: Thu, 03 Jan 2013 09:20:34 +0100 [thread overview]
Message-ID: <50E53F52.2000101@redhat.com> (raw)
In-Reply-To: <20130102155658.GC12357@stefanha-thinkpad.redhat.com>
On 01/02/13 16:56, Stefan Hajnoczi wrote:
> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote:
>> The spice_server pointer is a global variable and
>> vm_change_state_handler() therefore does not use its opaque parameter.
>>
>> The vm change state handler is added with a pointer to the spice_server
>> pointer. This is useless and we probably would not want 2 levels of
>> pointers.
> Gerd, would you like to take this through the spice queue or should I
> put it in trivial-patches?
Taking through trivial is fine with me, especially as the spice patch
queue is empty atm ;)
thanks,
Gerd
next prev parent reply other threads:[~2013-01-03 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 13:07 [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque Stefan Hajnoczi
2012-12-19 15:39 ` Uri Lublin
2013-01-02 15:56 ` Stefan Hajnoczi
2013-01-03 8:20 ` Gerd Hoffmann [this message]
2013-01-03 10:57 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E53F52.2000101@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).