From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqg2d-00082q-3U for qemu-devel@nongnu.org; Thu, 03 Jan 2013 03:20:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqg2c-0004re-3m for qemu-devel@nongnu.org; Thu, 03 Jan 2013 03:20:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqg2b-0004rJ-Sk for qemu-devel@nongnu.org; Thu, 03 Jan 2013 03:20:42 -0500 Message-ID: <50E53F52.2000101@redhat.com> Date: Thu, 03 Jan 2013 09:20:34 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1355922436-8378-1-git-send-email-stefanha@redhat.com> <20130102155658.GC12357@stefanha-thinkpad.redhat.com> In-Reply-To: <20130102155658.GC12357@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , Uri Lublin , qemu-devel@nongnu.org On 01/02/13 16:56, Stefan Hajnoczi wrote: > On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: >> The spice_server pointer is a global variable and >> vm_change_state_handler() therefore does not use its opaque parameter. >> >> The vm change state handler is added with a pointer to the spice_server >> pointer. This is useless and we probably would not want 2 levels of >> pointers. > Gerd, would you like to take this through the spice queue or should I > put it in trivial-patches? Taking through trivial is fine with me, especially as the spice patch queue is empty atm ;) thanks, Gerd