From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqp95-0005IQ-HT for qemu-devel@nongnu.org; Thu, 03 Jan 2013 13:04:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqp92-0000bc-Si for qemu-devel@nongnu.org; Thu, 03 Jan 2013 13:03:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqp92-0000bR-KE for qemu-devel@nongnu.org; Thu, 03 Jan 2013 13:03:56 -0500 Message-ID: <50E5C7F6.7040701@redhat.com> Date: Thu, 03 Jan 2013 11:03:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1356770725-4804-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1356770725-4804-4-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1356770725-4804-4-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA071109D3A101B825E3FA5E2" Subject: Re: [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA071109D3A101B825E3FA5E2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/29/2012 01:45 AM, Wenchao Xia wrote: > Switch the filename getting from parameter to block function, > now collect_image_info depends only on *bs. >=20 > Signed-off-by: Wenchao Xia > --- > qemu-img.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/qemu-img.c b/qemu-img.c > index 5a4df3a..d70435f 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -1180,15 +1180,17 @@ static void dump_json_image_info(ImageInfo *inf= o) > QDECREF(str); > } > =20 > +/* Assume bs is already openned. */ s/openned/opened/ Once that is fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA071109D3A101B825E3FA5E2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ5cf2AAoJEKeha0olJ0NqSQIH+wUVPRb17niNOOBdDEP2wCZz tOB1zUx6jHU13fiP1NdQb0xC4BBNYSwPE2Z06okAcfQblUEj5rDQbkTvUmTUIv6J 1U7RB4V+oytoKrv4/U5T6TkL7ttug/n6M4affPhxJwfbETLtFezT42qnxetGBBMi uKaWq04Ss+6D37r31njwIDWAdb724cJoikqC/XiPezGrtEqDU90SdwK5/xm8ZBTF LC1WgEHgIK5Mx0xMBGwCIgVw3cB57lXLHm6v8zkbYtN0rPBdURCXyZ1VldGxag2s 3pcu+tNNs/PBV4E6u8mCbUBd84d4ve8OM82Eguwqfp6WClpM3dTMgrwjioExa3E= =eji+ -----END PGP SIGNATURE----- --------------enigA071109D3A101B825E3FA5E2--