From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqxXY-00015H-AD for qemu-devel@nongnu.org; Thu, 03 Jan 2013 22:01:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqxXX-0001nP-6C for qemu-devel@nongnu.org; Thu, 03 Jan 2013 22:01:48 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:41683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqxXW-0001mN-Kp for qemu-devel@nongnu.org; Thu, 03 Jan 2013 22:01:47 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Jan 2013 13:00:17 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 8BABB2CE804D for ; Fri, 4 Jan 2013 14:01:37 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r042o4cm59965442 for ; Fri, 4 Jan 2013 13:50:04 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0431ajp025200 for ; Fri, 4 Jan 2013 14:01:36 +1100 Message-ID: <50E645E3.70904@linux.vnet.ibm.com> Date: Fri, 04 Jan 2013 11:00:51 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1356601227-8707-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1356601227-8707-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 0/4] HMP: allow parsing for sub command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, chenwj@iis.sinica.edu.tw, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com Hi, Markus Any comments for this? There are other serials of patch need this infrastructure extension, so hope it can be reviewed faster.... > These patches enhance HMP to allow it parse 2nd level of commands, such > as info sub command list, which means now foldered command with parameter > is possible. > > V2: > Follow the way supposed by Markus, which make the infrastructure knows > there is possible a 2nd level of command exist, instead of a hack. In this > way extention of command folder level is easy. > Moved some code and better doc according to comments. > Removed the patch about info snapshots, which will goto another serial. > V3: > Move changelog position. > Split out code moving patch. > > Wenchao Xia (4): > HMP: add QDict to info callback handler > HMP: add infrastructure for sub command > HMP: move define of mon_cmds > HMP: add sub command table to info > > hmp-commands.hx | 3 +- > hmp.c | 36 ++++++++-------- > hmp.h | 36 ++++++++-------- > hw/i8259.c | 4 +- > hw/lm32_pic.c | 4 +- > hw/lm32_pic.h | 4 +- > hw/loader.c | 2 +- > hw/loader.h | 3 +- > hw/pc.h | 4 +- > hw/pcmcia.h | 2 +- > hw/qdev-monitor.c | 4 +- > hw/qdev-monitor.h | 4 +- > hw/sun4m.c | 4 +- > hw/sun4m.h | 4 +- > hw/usb.h | 2 +- > hw/usb/bus.c | 2 +- > hw/usb/host-bsd.c | 2 +- > hw/usb/host-linux.c | 2 +- > include/net/net.h | 2 +- > include/net/slirp.h | 2 +- > include/sysemu/sysemu.h | 4 +- > monitor.c | 108 +++++++++++++++++++++------------------------- > net/net.c | 2 +- > net/slirp.c | 2 +- > savevm.c | 2 +- > vl.c | 2 +- > 26 files changed, 119 insertions(+), 127 deletions(-) > > -- Best Regards Wenchao Xia