From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rtc: skip year-2038 overflow check in case time_t is 32bit only
Date: Fri, 04 Jan 2013 11:22:06 +0100 [thread overview]
Message-ID: <50E6AD4E.4030007@suse.de> (raw)
In-Reply-To: <1357292585-26746-1-git-send-email-kraxel@redhat.com>
Am 04.01.2013 10:43, schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> tests/rtc-test.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/tests/rtc-test.c b/tests/rtc-test.c
> index 02edbf5..548200a 100644
> --- a/tests/rtc-test.c
> +++ b/tests/rtc-test.c
> @@ -201,6 +201,10 @@ static void set_year_20xx(void)
> g_assert_cmpint(cmos_read(RTC_YEAR), ==, 0x11);
> g_assert_cmpint(cmos_read(RTC_CENTURY), ==, 0x20);
>
> + if (sizeof(time_t) == 32) {
You sure that shouldn't be 4 then?
Andreas
> + return;
> + }
> +
> /* Set a date in 2080 to ensure there is no year-2038 overflow. */
> cmos_write(RTC_REG_A, 0x76);
> cmos_write(RTC_YEAR, 0x80);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-04 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 9:43 [Qemu-devel] [PATCH] rtc: skip year-2038 overflow check in case time_t is 32bit only Gerd Hoffmann
2013-01-04 10:22 ` Andreas Färber [this message]
2013-01-04 12:47 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6AD4E.4030007@suse.de \
--to=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).