From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr70H-0003vl-UW for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:08:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tr70G-0001YH-Au for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:08:05 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39998 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr70G-0001L6-0m for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:08:04 -0500 Message-ID: <50E6D403.4070900@suse.de> Date: Fri, 04 Jan 2013 14:07:15 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1357287364-24921-1-git-send-email-kraxel@redhat.com> <50E6AEDB.7060906@suse.de> <50E6D1B1.7010608@redhat.com> In-Reply-To: <50E6D1B1.7010608@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/4] test and debug devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "lmr@redhat.com" , =?ISO-8859-15?Q?Herv=E9_Poussineau?= , qemu-devel@nongnu.org, Anthony Liguori Hi Gerd, Am 04.01.2013 13:57, schrieb Gerd Hoffmann: >>> This patch series improves the debug devices we have. isa-debugcon i= s >>> switched over to the memory api. isa-debug-exit is added and replace= s >>> the hard-coded bochs debug port. pc-testdev (used by kvm-unit-tests)= is >>> added. >> >> Missing some CCs, and I was actually expecting another PATCH series >> first... as brought up before it is refreshing an uncommitted series b= y >> Herv=E9 without any mention thereof in the commit message >=20 > Hmm? The isa-debug-exit patch is written by myself. After hacking it > up I've noticed Herve wrote a simliar one. But I didn't grab Herve's > patch. I've picked up + updated Lucas' testdev patch, and that is > clearly visible in the commit message. >=20 >> and I thought >> there was an unanswered question to Anthony on both Lucas' and Herv=E9= 's >> series? >=20 > The only outstanding question I'm aware of is whenever anthony does a > outb or outw on the bochs debug port in his test suite. My > isa-debug-exit device handles both cases, so we should be fine here, an= d > I'm sure Anthony will actually try before committing the series ;) >=20 > What else is unanswered? I believe the original unanswered question was whether it is okay for Anthony to add -device foo for his testing now that the default port was changed to what he was relying on or whether he wants it to automatically get instantiated for machine backwards compatibility unless --no-defaults (or whatever it's called) is used. Your series, just like Herv=E9's that got stopped by Anthony, simple moves things into a standalone device in 2/4 and I don't see any pc-1.3 handling in 4/4. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg