From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr75T-0005Nr-Ib for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:13:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tr75S-0003O4-E2 for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:13:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40250 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr75S-0003Ny-4U for qemu-devel@nongnu.org; Fri, 04 Jan 2013 08:13:26 -0500 Message-ID: <50E6D571.9050504@suse.de> Date: Fri, 04 Jan 2013 14:13:21 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1356829329-30082-1-git-send-email-akong@redhat.com> <1356829329-30082-2-git-send-email-akong@redhat.com> <20121230011013.GA1742@t430s.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Autotest PATCH 2/2] virt run: add three logical case filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lucas Meneghel Rodrigues Cc: Yuri Tsarev , Amos Kong , autotest-kernel@redhat.com, qemu-devel@nongnu.org, virt-test-devel@redhat.com Am 31.12.2012 20:55, schrieb Lucas Meneghel Rodrigues: > Hmmm, about this one, I'm worried about making things more complex... >=20 > The way I see the problem at hand, I'd say if people want to customize > things, they'd be better of creating their own, specialized config > files rather than adding command line flags to manipulate the test > sets. >=20 > So my initial stand on this particular patch is NACK, but you might > convince me otherwise :) Lucas, following your nice presentation at KVM Forum I have set up virt-test for local testing of my core CPU refactorings. When run using ./run -t kvm --qemu-bin=3D/.../x86_64-softmmu/qemu-system-x86_64 it runs only 13 migration tests: (1/13) migrate.default.tcp: PASS (41.04 s) (2/13) migrate.default.unix: PASS (21.88 s) (3/13) migrate.default.exec: PASS (20.84 s) (4/13) migrate.default.fd: PASS (23.04 s) (5/13) migrate.default.mig_cancel: PASS (18.66 s) (6/13) migrate.with_set_speed.tcp: PASS (19.22 s) (7/13) migrate.with_set_speed.unix: PASS (19.07 s) (8/13) migrate.with_set_speed.exec: PASS (19.03 s) (9/13) migrate.with_set_speed.fd: PASS (18.93 s) (10/13) migrate.with_reboot.tcp: PASS (40.97 s) (11/13) migrate.with_reboot.unix: PASS (42.90 s) (12/13) migrate.with_reboot.exec: PASS (47.04 s) (13/13) migrate.with_reboot.fd: PASS (47.95 s) Whereas --list-tests shows 274 tests. So while I am impartial to this specific patch, some easy way to run a comprehensive test coverage without having to manually name each test using --tests=3D would be very handy! Something like --all-tests maybe? If there is such a thing already, it is not obvious to the novice user and --help output may need to be extended. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg