qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "KONRAD Frédéric" <fred.konrad@greensocs.com>
To: fred.konrad@greensocs.com, aliguori@us.ibm.com, afaerber@suse.de
Cc: peter.maydell@linaro.org, e.voevodin@samsung.com,
	mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de,
	stefanha@redhat.com, cornelia.huck@de.ibm.com
Subject: Re: [Qemu-devel] [RFC V9 09/12] virtio-blk-pci : switch to new API.
Date: Fri, 04 Jan 2013 14:57:56 +0100	[thread overview]
Message-ID: <50E6DFE4.9080807@greensocs.com> (raw)
In-Reply-To: <1357224744-14443-10-git-send-email-fred.konrad@greensocs.com>

On 03/01/2013 15:52, fred.konrad@greensocs.com wrote:
> +
> +static int virtio_blk_pci_init(VirtIOPCIProxy *vpci_dev)
> +{
> +    VirtIOBlkPCI *dev = VIRTIO_BLK_PCI(vpci_dev);
> +    virtio_blk_set_conf(dev->vdev, &(dev->blk));
> +    qdev_set_parent_bus(dev->vdev, BUS(vpci_dev->bus));
> +    if (qdev_init(dev->vdev) < 0) {
> +        return -1;
> +    }
> +    return 0;
> +}
> +static void virtio_blk_pci_instance_init(Object *obj)
> +{
> +    VirtIOBlkPCI *dev = VIRTIO_BLK_PCI(obj);
> +    dev->vdev = DEVICE(object_new("virtio-blk"));
> +    object_property_add_child(obj, "virtio-backend", OBJECT(dev->vdev), NULL);
> +}
Is that part better than the RFC V8 one ?

Thanks,

Fred

  reply	other threads:[~2013-01-04 13:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03 14:52 [Qemu-devel] [RFC V9 00/12] Virtio refactoring fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 01/12] qdev : add a maximum device allowed field for the bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 02/12] virtio-bus : introduce virtio-bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 03/12] virtio-pci-bus : introduce virtio-pci-bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 04/12] virtio-pci : refactor virtio-pci device fred.konrad
2013-01-04 20:36   ` Blue Swirl
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 05/12] virtio-device : refactor virtio-device fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 06/12] virtio-s390-bus : add virtio-s390-bus fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 07/12] virtio-s390-device : create a virtio-s390-bus during init fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 08/12] virtio-blk : add the virtio-blk device fred.konrad
2013-01-04 20:35   ` Blue Swirl
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 09/12] virtio-blk-pci : switch to new API fred.konrad
2013-01-04 13:57   ` KONRAD Frédéric [this message]
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 10/12] virtio-blk-s390 : switch to the " fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 11/12] virtio-blk : cleanup : use QOM cast fred.konrad
2013-01-03 14:52 ` [Qemu-devel] [RFC V9 12/12] virtio-blk : cleanup : remove qdev field fred.konrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E6DFE4.9080807@greensocs.com \
    --to=fred.konrad@greensocs.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=e.voevodin@samsung.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).