qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: virt-test-devel@redhat.com, Yuri Tsarev <ytsarev@suse.com>,
	autotest-kernel@redhat.com, qemu-devel@nongnu.org,
	Lucas Meneghel Rodrigues <lookkas@gmail.com>
Subject: Re: [Qemu-devel] [Autotest] [Autotest PATCH 2/2] virt run: add three logical case filters
Date: Fri, 04 Jan 2013 12:21:10 -0200	[thread overview]
Message-ID: <50E6E556.1070807@redhat.com> (raw)
In-Reply-To: <50E6D571.9050504@suse.de>

On 01/04/2013 11:13 AM, Andreas Färber wrote:
> Am 31.12.2012 20:55, schrieb Lucas Meneghel Rodrigues:
>> Hmmm, about this one, I'm worried about making things more complex...
>>
>> The way I see the problem at hand, I'd say if people want to customize
>> things, they'd be better of creating their own, specialized config
>> files rather than adding command line flags to manipulate the test
>> sets.
>>
>> So my initial stand on this particular patch is NACK, but you might
>> convince me otherwise :)
>
> Lucas, following your nice presentation at KVM Forum I have set up
> virt-test for local testing of my core CPU refactorings.
> When run using
> ./run -t kvm --qemu-bin=/.../x86_64-softmmu/qemu-system-x86_64
> it runs only 13 migration tests:
>
> (1/13) migrate.default.tcp: PASS (41.04 s)
> (2/13) migrate.default.unix: PASS (21.88 s)
> (3/13) migrate.default.exec: PASS (20.84 s)
> (4/13) migrate.default.fd: PASS (23.04 s)
> (5/13) migrate.default.mig_cancel: PASS (18.66 s)
> (6/13) migrate.with_set_speed.tcp: PASS (19.22 s)
> (7/13) migrate.with_set_speed.unix: PASS (19.07 s)
> (8/13) migrate.with_set_speed.exec: PASS (19.03 s)
> (9/13) migrate.with_set_speed.fd: PASS (18.93 s)
> (10/13) migrate.with_reboot.tcp: PASS (40.97 s)
> (11/13) migrate.with_reboot.unix: PASS (42.90 s)
> (12/13) migrate.with_reboot.exec: PASS (47.04 s)
> (13/13) migrate.with_reboot.fd: PASS (47.95 s)
>
> Whereas --list-tests shows 274 tests.
>
> So while I am impartial to this specific patch, some easy way to run a
> comprehensive test coverage without having to manually name each test
> using --tests= would be very handy! Something like --all-tests maybe?

Hmm, could be. Due to the long time it'd be needed to run --all-tests, I 
thought it wouldn't be necessary.

> If there is such a thing already, it is not obvious to the novice user
> and --help output may need to be extended.

One thing that does help here is to know that you can specify only the 
first component of the test name displayed on --help, and it'll run all 
derivated tests. For example, if you want to run all virtio_console 
tests, you can just specify:

./run -t kvm --qemu-bin=/path/to/qemu --tests virtio_console

SETUP: PASS (1.60 s)
DATA DIR: /home/area/virt_test/
DEBUG LOG: 
/home/lmr/Code/virt-test.git/logs/run-2013-01-04-12.20.20/debug.log
TESTS: 118
(1/118) 
virtio_console.spread_linear.specifiable.virtserialport.with_vm.open:

I need to think of a good way of exposing this information on help output...

  reply	other threads:[~2013-01-04 14:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-30  1:02 [Qemu-devel] [Autotest PATCH 1/2] virt run: fix typo in help message Amos Kong
2012-12-30  1:02 ` [Qemu-devel] [Autotest PATCH 2/2] virt run: add three logical case filters Amos Kong
2012-12-30  1:10   ` Amos Kong
2012-12-31 19:55     ` Lucas Meneghel Rodrigues
2013-01-04 13:13       ` Andreas Färber
2013-01-04 14:21         ` Lucas Meneghel Rodrigues [this message]
2013-01-04 15:06         ` Gerd Hoffmann
2013-01-04 17:35           ` Lucas Meneghel Rodrigues
2013-01-05  8:52       ` [Qemu-devel] [Virt-test-devel] " Qingtang Zhou
2013-01-05 15:29         ` Lucas Meneghel Rodrigues
2012-12-31 19:52 ` [Qemu-devel] [Virt-test-devel] [Autotest PATCH 1/2] virt run: fix typo in help message Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E6E556.1070807@redhat.com \
    --to=lmr@redhat.com \
    --cc=afaerber@suse.de \
    --cc=autotest-kernel@redhat.com \
    --cc=lookkas@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virt-test-devel@redhat.com \
    --cc=ytsarev@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).