qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org,
	Bhushan Bharat-R65777 <R65777@freescale.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue
Date: Fri, 04 Jan 2013 10:25:45 -0500	[thread overview]
Message-ID: <50E6F479.4090002@linux.vnet.ibm.com> (raw)
In-Reply-To: <6501413C-7526-42DB-8824-C0638F59985A@suse.de>

If I've followed the conversation correctly this is what needs to be done:

1. Remove the level parameters from kvm_arch_get_registers and 
kvm_arch_put_registers.

2. Add a new bitmap parameter to kvm_arch_get_registers and 
kvm_arch_put_registers.

3. Define a bit that correlates to our current notion of "all runtime 
registers".  This bit, and all bits in this bitmap, would be 
architecture specific.

4. Remove the cpustate->kvm_sync_dirty field.  Replace it with a bitmap 
that tracks which bits are dirty and need to be synced back to KVM-land.

5. As we do today, we'll assume registers are dirty and turn on their 
corresponding bit in this new bitmap whenever we "get" the registers 
from KVM.

6. Add other bits as needed on a case by case basis.

Does this seem to match what was discussed, and what we want to do?


-- 
-- Jason J. Herne (jjherne@linux.vnet.ibm.com)

  reply	other threads:[~2013-01-04 15:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21 13:56 [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue Jason J. Herne
2013-01-03 13:56 ` Alexander Graf
2013-01-03 18:48   ` Jason J. Herne
2013-01-03 19:09     ` Alexander Graf
2013-01-04  1:38       ` Marcelo Tosatti
2013-01-04  4:22         ` Bhushan Bharat-R65777
2013-01-04  8:40           ` Alexander Graf
2013-01-04  8:57             ` Bhushan Bharat-R65777
2013-01-04  9:01               ` Alexander Graf
2013-01-04 10:23             ` Bhushan Bharat-R65777
2013-01-04 10:29               ` Alexander Graf
2013-01-04 10:32                 ` Bhushan Bharat-R65777
2013-01-04 10:36                   ` Alexander Graf
2013-01-04 11:01                     ` Bhushan Bharat-R65777
2013-01-04 11:03                       ` Alexander Graf
2013-01-04 15:25                         ` Jason J. Herne [this message]
2013-01-04 16:27                           ` Alexander Graf
2013-01-04 17:39                             ` Jason J. Herne
2013-01-06 14:43                               ` Bhushan Bharat-R65777
2013-01-07 15:43                             ` Jason J. Herne
2013-01-07 15:49                               ` Alexander Graf
2013-01-07 18:19                                 ` Jason J. Herne
2013-01-07 18:42                                   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E6F479.4090002@linux.vnet.ibm.com \
    --to=jjherne@linux.vnet.ibm.com \
    --cc=R65777@freescale.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).