From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, afaerber@suse.de, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH] pixman: fix warning
Date: Fri, 04 Jan 2013 16:47:58 +0100 [thread overview]
Message-ID: <50E6F9AE.70605@redhat.com> (raw)
In-Reply-To: <CAFEAcA8zeK6yz8GR-1WXgzL2LND02DFHRHHOoGshz8NVRuyJTA@mail.gmail.com>
Hi,
>> +/* pixman-0.16.0 headers have a redundant declaration */
>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wredundant-decls"
>> #include <pixman.h>
>> +#pragma GCC diagnostic pop
>
> IIRC we can't rely on gcc knowing about 'diagnostic push/pop' --
> eg in coroutine-ucontext.c we avoid using that for this reason.
Indeed, even '#pragma GCC diagnostic' isn't reliable.
/me goes grab stuff from coroutine-ucontext.c and run that through bunch
of testbuilds ...
cheers,
Gerd
prev parent reply other threads:[~2013-01-04 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 14:59 [Qemu-devel] [PATCH] pixman: fix warning Gerd Hoffmann
2013-01-04 15:16 ` Peter Maydell
2013-01-04 15:47 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6F9AE.70605@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).