* [Qemu-devel] [PATCH] pixman: fix warning
@ 2013-01-04 14:59 Gerd Hoffmann
2013-01-04 15:16 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2013-01-04 14:59 UTC (permalink / raw)
To: qemu-devel; +Cc: agraf, Gerd Hoffmann, afaerber
Cc: afaerber@suse.de
Cc: agraf@suse.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/ui/qemu-pixman.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
index 3c05c83..63b8ccc 100644
--- a/include/ui/qemu-pixman.h
+++ b/include/ui/qemu-pixman.h
@@ -6,7 +6,11 @@
#ifndef QEMU_PIXMAN_H
#define QEMU_PIXMAN_H
+/* pixman-0.16.0 headers have a redundant declaration */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wredundant-decls"
#include <pixman.h>
+#pragma GCC diagnostic pop
#include "console.h"
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] pixman: fix warning
2013-01-04 14:59 [Qemu-devel] [PATCH] pixman: fix warning Gerd Hoffmann
@ 2013-01-04 15:16 ` Peter Maydell
2013-01-04 15:47 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2013-01-04 15:16 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel, afaerber, agraf
On 4 January 2013 14:59, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Cc: afaerber@suse.de
> Cc: agraf@suse.de
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/ui/qemu-pixman.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
> index 3c05c83..63b8ccc 100644
> --- a/include/ui/qemu-pixman.h
> +++ b/include/ui/qemu-pixman.h
> @@ -6,7 +6,11 @@
> #ifndef QEMU_PIXMAN_H
> #define QEMU_PIXMAN_H
>
> +/* pixman-0.16.0 headers have a redundant declaration */
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wredundant-decls"
> #include <pixman.h>
> +#pragma GCC diagnostic pop
IIRC we can't rely on gcc knowing about 'diagnostic push/pop' --
eg in coroutine-ucontext.c we avoid using that for this reason.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] pixman: fix warning
2013-01-04 15:16 ` Peter Maydell
@ 2013-01-04 15:47 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2013-01-04 15:47 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, afaerber, agraf
Hi,
>> +/* pixman-0.16.0 headers have a redundant declaration */
>> +#pragma GCC diagnostic push
>> +#pragma GCC diagnostic ignored "-Wredundant-decls"
>> #include <pixman.h>
>> +#pragma GCC diagnostic pop
>
> IIRC we can't rely on gcc knowing about 'diagnostic push/pop' --
> eg in coroutine-ucontext.c we avoid using that for this reason.
Indeed, even '#pragma GCC diagnostic' isn't reliable.
/me goes grab stuff from coroutine-ucontext.c and run that through bunch
of testbuilds ...
cheers,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-04 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-04 14:59 [Qemu-devel] [PATCH] pixman: fix warning Gerd Hoffmann
2013-01-04 15:16 ` Peter Maydell
2013-01-04 15:47 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).