From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr9VC-0002jO-94 for qemu-devel@nongnu.org; Fri, 04 Jan 2013 10:48:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tr9V9-0007Fj-24 for qemu-devel@nongnu.org; Fri, 04 Jan 2013 10:48:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr9V8-0007Fa-QX for qemu-devel@nongnu.org; Fri, 04 Jan 2013 10:48:06 -0500 Message-ID: <50E6F9AE.70605@redhat.com> Date: Fri, 04 Jan 2013 16:47:58 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1357311593-27749-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pixman: fix warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, afaerber@suse.de, agraf@suse.de Hi, >> +/* pixman-0.16.0 headers have a redundant declaration */ >> +#pragma GCC diagnostic push >> +#pragma GCC diagnostic ignored "-Wredundant-decls" >> #include >> +#pragma GCC diagnostic pop > > IIRC we can't rely on gcc knowing about 'diagnostic push/pop' -- > eg in coroutine-ucontext.c we avoid using that for this reason. Indeed, even '#pragma GCC diagnostic' isn't reliable. /me goes grab stuff from coroutine-ucontext.c and run that through bunch of testbuilds ... cheers, Gerd