[Qemu-devel] [FYI] Testing new patch management scripts...

[Qemu-devel] [FYI] Testing new patch management scripts...

[Anthony Liguori]

Hi,

Over the holiday, I spent some time overhauling my patch tracking
scripts.  One new feature is automated responses so you will start
seeing some additional mail on the list.  Notably:

  1) My 'Thanks, applied.' mails are now automated.

  2) Patches that no longer apply via git am --3way will receive a
     notification.  

  3) Patches that don't build or fail qemu-test/kvm-autotest will also
     receive notification (I haven't enabled this yet but stay tuned).

Please bare with me as I work the kinks out.  I've got pretty
sophisticated detection of applied patches, obsolete patches, etc. but
I'm still working on the heuristics here.

Once I've worked out the major issues, I'll share the code with everyone.

Regards,

Anthony Liguori

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

[Stefan Hajnoczi]

On Wed, Jan 02, 2013 at 12:07:57PM -0600, Anthony Liguori wrote:
> Over the holiday, I spent some time overhauling my patch tracking
> scripts.  One new feature is automated responses so you will start
> seeing some additional mail on the list.  Notably:
> 
>   1) My 'Thanks, applied.' mails are now automated.
> 
>   2) Patches that no longer apply via git am --3way will receive a
>      notification.  
> 
>   3) Patches that don't build or fail qemu-test/kvm-autotest will also
>      receive notification (I haven't enabled this yet but stay tuned).
> 
> Please bare with me as I work the kinks out.  I've got pretty
> sophisticated detection of applied patches, obsolete patches, etc. but
> I'm still working on the heuristics here.
> 
> Once I've worked out the major issues, I'll share the code with everyone.

Cool, sounds useful for subsystem maintainers too.

Stefan

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

[Blue Swirl]

On Wed, Jan 2, 2013 at 6:07 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Hi,
>
> Over the holiday, I spent some time overhauling my patch tracking
> scripts.  One new feature is automated responses so you will start
> seeing some additional mail on the list.  Notably:
>
>   1) My 'Thanks, applied.' mails are now automated.
>
>   2) Patches that no longer apply via git am --3way will receive a
>      notification.
>
>   3) Patches that don't build or fail qemu-test/kvm-autotest will also
>      receive notification (I haven't enabled this yet but stay tuned).

Nice!

Checkpatch.pl support would be nice too. But since it's not error
free, automatic messages could be annoying.

Perhaps some integration with patchwork could be useful too.

>
> Please bare with me as I work the kinks out.  I've got pretty
> sophisticated detection of applied patches, obsolete patches, etc. but
> I'm still working on the heuristics here.
>
> Once I've worked out the major issues, I'll share the code with everyone.
>
> Regards,
>
> Anthony Liguori
>

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

[Daniel P. Berrange]

On Wed, Jan 02, 2013 at 12:07:57PM -0600, Anthony Liguori wrote:
> Hi,
> 
> Over the holiday, I spent some time overhauling my patch tracking
> scripts.  One new feature is automated responses so you will start
> seeing some additional mail on the list.  Notably:
> 
>   1) My 'Thanks, applied.' mails are now automated.
> 
>   2) Patches that no longer apply via git am --3way will receive a
>      notification.  
> 
>   3) Patches that don't build or fail qemu-test/kvm-autotest will also
>      receive notification (I haven't enabled this yet but stay tuned).
> 
> Please bare with me as I work the kinks out.  I've got pretty
> sophisticated detection of applied patches, obsolete patches, etc. but
> I'm still working on the heuristics here.
> 
> Once I've worked out the major issues, I'll share the code with everyone.

I look forward to seeing the code - it sounds like the kind of thing
that would be useful to adapt for libvirt patch tracking too.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

[Andreas Färber]

Hi,

Am 02.01.2013 19:07, schrieb Anthony Liguori:
>   2) Patches that no longer apply via git am --3way will receive a
>      notification.

Isn't Nacked-by too strong of a notification for a mere technical need
for a rebase (compared to a rejection of its concept/approach)?

Also, since quite a few of such messages have been appearing on the list
already, might it make sense to shorten the message and rather link to
some qemu.org Wiki page to spare subscribers' mailboxes?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

[Anthony Liguori]

Andreas Färber <afaerber@suse.de> writes:

> Hi,
>
> Am 02.01.2013 19:07, schrieb Anthony Liguori:
>>   2) Patches that no longer apply via git am --3way will receive a
>>      notification.
>
> Isn't Nacked-by too strong of a notification for a mere technical need
> for a rebase (compared to a rejection of its concept/approach)?

Yeah, I need some sort of tag though for tracking purposes..  Maybe
Rejected-by...

>
> Also, since quite a few of such messages have been appearing on the list
> already, might it make sense to shorten the message and rather link to
> some qemu.org Wiki page to spare subscribers' mailboxes?

I'm focusing at the moment on getting the code in shape to release.  We
can tweak the text bits over time.  Patches will only send one mail
per-thread so it's unlikely that it will ever cause a space problem even
in the stingiest of corporate mailbox quotas :-)

Regards,

Anthony Liguori

>
> Regards,
> Andreas
>
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

[Andreas Färber]

Am 05.01.2013 04:05, schrieb Anthony Liguori:
> Andreas Färber <afaerber@suse.de> writes:
>> Am 02.01.2013 19:07, schrieb Anthony Liguori:
>>>   2) Patches that no longer apply via git am --3way will receive a
>>>      notification.
>>
>> Isn't Nacked-by too strong of a notification for a mere technical need
>> for a rebase (compared to a rejection of its concept/approach)?
> 
> Yeah, I need some sort of tag though for tracking purposes..  Maybe
> Rejected-by...

Sorry, forgot to mention: I wanted to propose Bounced-by.

>> Also, since quite a few of such messages have been appearing on the list
>> already, might it make sense to shorten the message and rather link to
>> some qemu.org Wiki page to spare subscribers' mailboxes?
> 
> I'm focusing at the moment on getting the code in shape to release.  We
> can tweak the text bits over time.  Patches will only send one mail
> per-thread so it's unlikely that it will ever cause a space problem even
> in the stingiest of corporate mailbox quotas :-)

We shouldn't forgot non-corporate mailboxes since QEMU is a community
project. :-) I was rather thinking about disk space long-term though and
these messages mostly reaching core community members so far that don't
need detailed explaining.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg