From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TrG64-000453-9L for qemu-devel@nongnu.org; Fri, 04 Jan 2013 17:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TrG63-0004Ku-4m for qemu-devel@nongnu.org; Fri, 04 Jan 2013 17:50:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TrG62-0004Kp-TF for qemu-devel@nongnu.org; Fri, 04 Jan 2013 17:50:39 -0500 Message-ID: <50E75C94.4040406@redhat.com> Date: Fri, 04 Jan 2013 15:49:56 -0700 From: Eric Blake MIME-Version: 1.0 References: <1356770725-4804-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1356770725-4804-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1356770725-4804-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4A83949CDDFEB5E66E8D2702" Subject: Re: [Qemu-devel] [PATCH 05/11] block: rename bdrv_query_info to bdrv_query_block_info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4A83949CDDFEB5E66E8D2702 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/29/2012 01:45 AM, Wenchao Xia wrote: > Now this function have a mirror name with bdrv_query_image_info > to tip well what it is doing. Awkward to read. Maybe: Now that we have bdrv_query_image_info, rename this function to make it more obvious what it is doing. >=20 > Signed-off-by: Wenchao Xia > --- > block.c | 4 ++-- > include/block/block.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4A83949CDDFEB5E66E8D2702 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ51yUAAoJEKeha0olJ0Nqlg8H/jNnt+io7FfVDtCtvr/HGm6S t5iw/3xtldIkXTUFy7ia05ojt5Qd07GTD8R0Zaq1ZiKH1LkDXq+5svoOCsOaNQrF SOfEBzcZCbU12ss+RI3gNB7L0bbZf6iuRqh5cmmq/AKkLhcvKlyElcElbeXvHNG6 sVogDlLwl1A1z3pU/yir4FJSk3nxO4B5tX5QqdQstP9di+KNLFWqWWVaS6meSxsC 5ZE6v0hUU1C79m9h9jCL6fzEodIDZW+0Iw61La/zkcC7vdHLXhlyaBddxSxKJPYX UueE8k1Mb1pPpWPryWIXpZSP6ZjlEwsy+2jcog2ZWupE1i42BPOHbtdQeRo2C5M= =XZS+ -----END PGP SIGNATURE----- --------------enig4A83949CDDFEB5E66E8D2702--