qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Brad Smith <brad@comstyle.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: change dist target to use xz
Date: Fri, 04 Jan 2013 17:41:41 -0700	[thread overview]
Message-ID: <50E776C5.5070809@redhat.com> (raw)
In-Reply-To: <20130105002806.GC11220@rox.home.comstyle.com>

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

On 01/04/2013 05:28 PM, Brad Smith wrote:
> On Thu, Aug 02, 2012 at 06:08:15AM -0400, Brad Smith wrote:
>> If a compression format other than gzip is used we might
>> as well move to xz instead of bzip2.

Agreed, many projects are dropping bzip2 as irrelevant (slower than the
more-widely-available gz, compresses worse than newcomer xz).

> +++ b/scripts/make-release
> @@ -20,5 +20,5 @@ git checkout "v${version}"
>  git submodule update --init
>  rm -rf .git roms/*/.git
>  popd
> -tar cfj ${destination}.tar.bz2 ${destination}
> +XZ_OPT=-9 tar cfJ ${destination}.tar.xz ${destination}

Do we really need -9?  For example, coreutils did an interesting
benchmark in its cfg.mk file, and chose to use -8e instead of -9 as a
result:

>> # Comparing tarball sizes compressed using different xz presets, we see that
>> # an -8e-compressed tarball is only 9KiB larger than the -9e-compressed one.
>> # Using -8e is preferred, since that lets the decompression process use half
>> # the memory (32MiB rather than 64MiB).
>> # $ for i in {7,8,9}{e,}; do \
>> #     (n=$(xz -$i < coreutils-8.15*.tar|wc -c);echo $n $i) & done |sort -nr
>> # 5129388 7
>> # 5036524 7e
>> # 5017476 8
>> # 5010604 9
>> # 4923016 8e
>> # 4914152 9e

Also, your use of tar cfJ assumes relatively new GNU tar; it won't work
on other systems (but this is a pre-existing non-portability, and may be
irrelevant, if you are willing to require that the only people likely to
make a release tarball are using appropriate tools).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

  reply	other threads:[~2013-01-05  0:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 10:08 [Qemu-devel] [PATCH] build: change dist target to use xz Brad Smith
2013-01-05  0:28 ` Brad Smith
2013-01-05  0:41   ` Eric Blake [this message]
2013-01-05  1:03     ` Brad Smith
2013-01-09  1:59       ` Brad Smith
2013-01-09  2:22 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E776C5.5070809@redhat.com \
    --to=eblake@redhat.com \
    --cc=brad@comstyle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).