From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsDL0-0006Va-3q for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsDKz-0006Ms-0F for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:06:02 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:48122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsDKy-0006Mo-O7 for qemu-devel@nongnu.org; Mon, 07 Jan 2013 09:06:00 -0500 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Jan 2013 14:05:01 -0000 Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r07E5mFh1311036 for ; Mon, 7 Jan 2013 14:05:48 GMT Received: from d06av12.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r07E5tqY025889 for ; Mon, 7 Jan 2013 07:05:56 -0700 Message-ID: <50EAD642.8080209@de.ibm.com> Date: Mon, 07 Jan 2013 15:05:54 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1355760006-891-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1355760006-891-1-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev: obey no_user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Anthony Liguori , "qemu-devel@nongnu.org" Ping? On 17/12/12 17:00, Christian Borntraeger wrote: > since > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > qdev: refactor device creation to allow bus_info to be set only in class > > A user can specify a device that is no_user. > For example on my i386 box, I can add a 2nd kvmvapic device. > > This patch checks for no-user and rejects the device_add. > > Signed-off-by: Christian Borntraeger > --- > hw/qdev-monitor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index a1b4d6a..b2c34e7 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -426,6 +426,11 @@ DeviceState *qdev_device_add(QemuOpts *opts) > } > > k = DEVICE_CLASS(obj); > + if (k->no_user) { > + qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "a driver name"); > + error_printf_unless_qmp("Try with argument 'help' for a list.\n"); > + return NULL; > + } > > /* find bus */ > path = qemu_opt_get(opts, "bus"); >